Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v14.15.3 proposal #36555

Merged
merged 2 commits into from
Dec 17, 2020
Merged

v14.15.3 proposal #36555

merged 2 commits into from
Dec 17, 2020

Conversation

BethGriggs
Copy link
Member

2020-12-17, Version 14.15.3 'Fermium' (LTS), @BethGriggs

Notable Changes

Node.js v14.15.2 included a commit that has caused reported breakages when cloning request objects. This release reverts the commit that introduced the behaviour change. See #36550 for more details.

Commits

  • [4264d9aa67] - Revert "http: lazy create IncomingMessage.headers" (Beth Griggs) #36553

@BethGriggs
Revert "http: lazy create IncomingMessage.headers"
4264d9a 
This reverts commit b58725c.

Fixes: #36550

PR-URL: #36553
Refs: #35281
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Dec 17, 2020
@BethGriggs BethGriggs changed the base branch from master to v14.x December 17, 2020 19:03
@BethGriggs
2020-12-17, Version 14.15.3 'Fermium' (LTS)
e725355 
Notable Changes:

Node.js v14.15.2 included a commit that has caused reported breakages
when cloning request objects. This release reverts the commit that
introduced the behaviour change.

See #36550 for more details.

PR-URL: #36555
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/34992/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/3618/ ✅

MylesBorins
MylesBorins approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs
Copy link
Member Author

Release build on e725355 - https://ci-release.nodejs.org/job/iojs+release/6537 ✅

BethGriggs added a commit that referenced this pull request Dec 17, 2020
@BethGriggs
Working on v14.15.4
dd8fb22 
PR-URL: #36555
@BethGriggs BethGriggs merged commit e725355 into v14.x Dec 17, 2020
BethGriggs added a commit that referenced this pull request Dec 17, 2020
@BethGriggs
2020-12-17, Version 14.15.3 'Fermium' (LTS)
b49145f 
Notable Changes:

Node.js v14.15.2 included a commit that has caused reported breakages
when cloning request objects. This release reverts the commit that
introduced the behaviour change.

See #36550 for more details.

PR-URL: #36555
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Dec 17, 2020
@BethGriggs
Blog: v14.15.3 release post
56d7893 
PR-URL: nodejs/node#36555
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Dec 17, 2020
@BethGriggs
Blog: v14.15.3 release post
8764f0d 
Refs: nodejs/node#36555
@BethGriggs BethGriggs mentioned this pull request Dec 17, 2020
Merged
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Dec 17, 2020
@BethGriggs
Blog: v14.15.3 release post (#3582)
cf79bb1 
Refs: nodejs/node#36555
@BethGriggs BethGriggs deleted the v14.15.3-proposal branch December 17, 2020 23:36
@targos targos added release Issues and PRs related to Node.js releases. v14.x and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Sep 27, 2021
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Sep 13, 2022
Open
This was referenced Sep 13, 2022
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Sep 14, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BethGriggs @nodejs-github-bot @MylesBorins @richardlau @targos