Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: cleanup ClientRequest oncreate #36862

Closed
wants to merge 2 commits into from
Closed

http: cleanup ClientRequest oncreate #36862

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 10, 2021 •
edited
Loading

Iterative work towards cleaning up ClientRequest.

@ronag ronag added the http Issues or PRs related to the http subsystem. label Jan 10, 2021
@ronag ronag requested review from Trott and BridgeAR January 10, 2021 10:04
@ronag
Copy link
Member Author

ronag commented Jan 10, 2021

@nodejs/http

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35444/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35447/

Trott
Trott approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we run a subset of the http benchmarks before landing? @mscdex

@nodejs/http

mcollina
mcollina approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dnlup
dnlup approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@dnlup dnlup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnlup
Copy link
Contributor

dnlup commented Jan 15, 2021

@Trott is benchmark-node-micro-benchmarks the CI job for running benchmarks in this list?

@ronag
Copy link
Member Author

ronag commented Jan 15, 2021

@dnlup Do you want to try and land this?

@dnlup
Copy link
Contributor

dnlup commented Jan 15, 2021

@dnlup Do you want to try and land this?

@ronag Yes 👍🏻 . I'll run the benchmark job on the http subsystem first.

@dnlup
Copy link
Contributor

dnlup commented Jan 15, 2021

https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/897/

@dnlup
Copy link
Contributor

dnlup commented Jan 16, 2021

The job is pretty long. It's still running. I don't see performance regressions so far, inspecting the job console output.

dnlup pushed a commit that referenced this pull request Jan 16, 2021
@ronag @dnlup
http: cleanup ClientRequest oncreate
963dec3 
PR-URL: #36862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
@dnlup
Copy link
Contributor

dnlup commented Jan 16, 2021 •
edited
Loading

Landed in 963dec3

@dnlup dnlup closed this Jan 16, 2021
@Trott
Copy link
Member

Trott commented Jan 19, 2021

@dnlup The http benchmarks take a long time to run, so it's usually a good idea to use the filter option to run a subset of the http benchmarks. In this case, I think using request as the value for FILTER would have limited the benchmarks to just client-request-body.js and create-clientrequest.js.

I'll open a draft revert PR so we can see that benchmark. Assuming no significant performance issues, I'll close the draft revert PR.

@dnlup
Copy link
Contributor

dnlup commented Jan 19, 2021

@dnlup The http benchmarks take a long time to run, so it's usually a good idea to use the filter option to run a subset of the http benchmarks. In this case, I think using request as the value for FILTER would have limited the benchmarks to just client-request-body.js and create-clientrequest.js.

I'll open a draft revert PR so we can see that benchmark. Assuming no significant performance issues, I'll close the draft revert PR.

@Trott thank you for the explanation. I apologize for the extra work I caused.

ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@ronag @ruyadorno
http: cleanup ClientRequest oncreate
80051ab 
PR-URL: #36862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
@Trott
Copy link
Member

Trott commented Feb 14, 2021

@Trott thank you for the explanation. I apologize for the extra work I caused.

No worries at all. I was only letting you know in case this is an area where you plan on doing other similar work and may need to run another http benchmark.

targos pushed a commit that referenced this pull request May 1, 2021
@ronag @targos
http: cleanup ClientRequest oncreate
e7bc379 
PR-URL: #36862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlup dnlup dnlup approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@mscdex mscdex Awaiting requested review from mscdex

@benjamingr benjamingr Awaiting requested review from benjamingr

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @dnlup @Trott @mcollina @mscdex