Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v15.7.0 proposal #37020

Merged
merged 81 commits into from
Jan 26, 2021
Merged

v15.7.0 proposal #37020

merged 81 commits into from
Jan 26, 2021

Conversation

ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Jan 22, 2021 •
edited
Loading

2021-01-26, Version 15.7.0 (Current), @ruyadorno

Notable changes

  • buffer:
    • introduce Blob (James M Snell) #36811
    • add base64url encoding option (Filip Skokan) #36952
  • crypto:
    • experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
  • doc:
  • fs:
    • allow position parameter to be a BigInt in read and readSync (raisinten) #36190
  • http:
    • attach request as res.req (Ian Storm Taylor) #36505
    • expose urlToHttpOptions utility (Yongsheng Zhang) #35960

Commits

  • [2692d0bd5e] - (SEMVER-MINOR) buffer: introduce Blob (James M Snell) #36811
  • [832cd015d5] - (SEMVER-MINOR) buffer: add base64url encoding option (Filip Skokan) #36952
  • [acb1a71a7d] - build: fix compiling against openssl with no-psk (Caleb ツ Everett) #36881
  • [68ffe5a406] - (SEMVER-MINOR) crypto: experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879
  • [b7d8e61ef1] - crypto: fix randomInt bias (Tobias Nießen) #36894
  • [1149af6265] - (SEMVER-MINOR) crypto: add keyObject.asymmetricKeyDetails for asymmetric keys (Filip Skokan) #36188
  • [0398167b35] - crypto: fix WebCrypto import of RSA-PSS keys (Tobias Nießen) #36877
  • [9ffe67b3a9] - deps: upgrade npm to 7.4.3 (Ruy Adorno) #37018
  • [d684cbdda3] - deps: update ICU to 68.2 (Michaël Zasso) #36980
  • [fdb9812134] - deps: V8: cherry-pick fe191e8d05cc (Benjamin Coe) #36956
  • [6f773fbe84] - deps: upgrade npm to 7.4.2 (Ruy Adorno) #36953
  • [95889c1fdc] - doc: fix maintaining ICU guide (Michaël Zasso) #36980
  • [0c9e2d0650] - doc: add @RaisinTen to collaborators (Darshan Sen) #36998
  • [01c24aafc2] - doc: fix typo in http.server.requestTimout docs (alexbs) #36987
  • [7083d99803] - doc: add performance notes for fs.readFile (James M Snell) #36880
  • [5693ed9df1] - doc: clarify maxSockets option of http.Agent (Pooja D P) #36941
  • [9531922a76] - doc: remove pull-requests.md preamble (Rich Trott) #36960
  • [4980cf70c3] - doc: fix module.isPreloading documentation (Antoine du Hamel) #36944
  • [48b6781151] - doc: fix crypto.generateKeySync aes allowed length list (Filip Skokan) #36928
  • [120db2c169] - doc: fix grammar and link to QUIC in changelog (Dan Dascalescu) #36959
  • [af0f0a0f65] - doc: fix percentile range in perf_hooks.md (raisinten) #36938
  • [8cf280d9ab] - doc: improve perf_hooks docs (Juan José Arboleda) #36909
  • [3ea37c2d67] - doc: fix invalid HTML in doc template (Rich Trott) #36930
  • [eaf378aa46] - doc: remove issue template duplication from contributing docs (Rich Trott) #36908
  • [7a794417f3] - doc: remove resolving-a-bug-report from contributing docs (Rich Trott) #36905
  • [707b97307d] - doc: use ESM syntax for WASI example (Antoine du Hamel) #36848
  • [5a9a07e7cd] - doc: add iansu to collaborators (Ian Sutherland) #36951
  • [aa3bc74cd6] - doc: fixup typo in metadata entry (James M Snell) #36947
  • [22e29ccfa3] - doc: add alternative version links to the packages page (Filip Skokan) #36915
  • [80c84a1136] - doc: add miladfarca to collaborators (Milad Fa) #36934
  • [e73b1072f3] - doc: update tls test to use better terminology (Michael Dawson) #36851
  • [5cbf638c06] - doc: remove unnecessary contributing.md section (Rich Trott) #36891
  • [f99b38fedd] - doc: wrap TOC in a <details> tag (Mattia Pontonio) #36896
  • [82eccddf1e] - doc: update fs.l/statSync API history for throwIfNoEntry (Andrew Casey) #36882
  • [70cd43c32e] - doc: change "it's" to "its" where necessary (Tobias Nießen) #36913
  • [02a8f52040] - doc: fix indentation on http2 doc entry (Rich Trott) #36869
  • [abf0477c9e] - events: remove error listener on signal abort (ZiJian Liu) #36969
  • [c4cdf1d830] - (SEMVER-MINOR) fs: allow position parameter to be a BigInt in read and readSync (raisinten) #36190
  • [0ee168c896] - (SEMVER-MINOR) http: attach request as res.req (Ian Storm Taylor) #36505
  • [82c05f5def] - http: abortIncoming only on socket close (Robert Nagy) #36821
  • [aa7243e3d4] - http: refactor ClientRequest destroy (Robert Nagy) #36863
  • [80051abfcb] - http: cleanup ClientRequest oncreate (Robert Nagy) #36862
  • [f5b8e7b068] - http2: refactor to avoid unsafe array iteration (Antoine du Hamel) #36700
  • [91f94abbd1] - lib: refactor to use validateArray (ZiJian Liu) #36982
  • [b3ca53985b] - lib: remove non used getter in lib/perf\_hooks.js (Juan José Arboleda) #36907
  • [f2ac4bb8e2] - lib: expose primordials object (Antoine du Hamel) #36872
  • [850d3578b6] - lib: refactor primordials.makeSafe to use more primordials (ExE Boss) #36865
  • [b86c48cc91] - lib: refactor source_map to use more primordials (Antoine du Hamel) #36733
  • [1ef92f61fa] - lib: refactor source_map to avoid unsafe array iteration (Antoine du Hamel) #36734
  • [543ecbdbd8] - module: simplify tryStatSync with throwIfNoEntry option (Antoine du Hamel) #36971
  • [d3f7280e75] - os: performance improvement in vector allocation (Yash Ladha) #36748
  • [327a2b7801] - perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN (ZiJian Liu) #36937
  • [d29c0a9bb7] - repl: refactor to avoid unsafe array iteration (raisinten) #36663
  • [eef77e46c4] - src: use BaseObject::kInteralFieldCount in Blob (Joyee Cheung) #36991
  • [9254791528] - src: replace push_back with emplace_back in debug_utils (raisinten) #36897
  • [3c12941359] - src: use BaseObject::kInternalFieldCount in X509Certificate constructor (Joyee Cheung) #36892
  • [3a122aa246] - test: mark flaky tests on IBM i (Richard Lau) #36986
  • [d73d58d595] - (SEMVER-MINOR) test: add wpt tests for Blob (Michaël Zasso) #36811
  • [951a78bc34] - test: increase buffer list coverage (Emil Sivervik) #36688
  • [3d20415871] - test: fix warning in test_environment.cc (raisinten) #36846
  • [e285a7a76d] - test: remove unused ecdhPeerKey (Daniel Bevenius) #36942
  • [ba87be0b0e] - test: improve coverage for Module getters (Juan José Arboleda) #36950
  • [c7dd9c8c69] - test: skip internet for test-npm-install (Ruy Adorno) #36933
  • [3bbe9a5588] - test: improve coverage on worker threads (Juan José Arboleda) #36910
  • [f589bb2052] - test: improve coverage at lib/internal/vm/module.js (Juan José Arboleda) #36898
  • [8a8241529e] - Revert "test: mark test-cluster-bind-privileged-port flaky on arm" (Rod Vagg) #36884
  • [99c15909ad] - test: fixup flaky test-crypto-x509 on windows (James M Snell) #36966
  • [c2ec15aff6] - test: check mustCall errors in test-fs-read-type (Tobias Nießen) #36914
  • [30b2aac98a] - test: fix variable name for non-RSA keys (Tobias Nießen) #36912
  • [d97917faef] - test,benchmark: stop requiring URL and URLSearchParams (raisinten) #36927
  • [864b97b24d] - tls: use recently added matching SecureContext in default SNICallback (Mateusz Krawczuk) #36072
  • [61257013f6] - tools: cleanup old ICU version-specific fixes (Michaël Zasso) #36980
  • [8e02b53b09] - tools: update ESLint to 7.18.0 (Colin Ihrig) #36955
  • [8dc8adc782] - tools: add support for top-level await syntax in linter (Antoine du Hamel) #36911
  • [4cd471e685] - tools,doc: list the stability status of each API (Zijian Liu) #36223
  • [889654d36c] - url: align url format behavior with browsers (ZiJian Liu) #36903
  • [64fed319ef] - (SEMVER-MINOR) url: expose urlToHttpOptions utility (Yongsheng Zhang) #35960
  • [d676324b66] - util: prefer Reflect.ownKeys(…) (ExE Boss) #36740
  • [0d719476e0] - vm: refactor to avoid unsafe array iteration (Antoine du Hamel) #36752
  • [bf695ebdb1] - worker: refactor to avoid unsafe array iteration (Antoine du Hamel) #36735
  • [403b595ef5] - zlib: refactor to avoid unsafe array iteration (Antoine du Hamel) #36722

Trott and others added 30 commits January 21, 2021 17:48
@Trott @ruyadorno
doc: fix indentation on http2 doc entry
02a8f52 
PR-URL: #36869
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@RaisinTen @ruyadorno
fs: allow position parameter to be a BigInt in read and readSync
c4cdf1d 
Fixes: #36185

PR-URL: #36190
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@tniessen @ruyadorno
crypto: fix WebCrypto import of RSA-PSS keys
0398167 
This patch changes GetRsaKeyDetail to work in older supported versions
of OpenSSL.

Refs: openssl/openssl#10217

PR-URL: #36877
Refs: #36188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 @ruyadorno
worker: refactor to avoid unsafe array iteration
bf695eb 
PR-URL: #36735
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 @ruyadorno
vm: refactor to avoid unsafe array iteration
0d71947 
PR-URL: #36752
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 @ruyadorno
lib: refactor source_map to avoid unsafe array iteration
1ef92f6 
PR-URL: #36734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@aduh95 @ruyadorno
zlib: refactor to avoid unsafe array iteration
403b595 
PR-URL: #36722
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@aduh95 @ruyadorno
lib: refactor source_map to use more primordials
b86c48c 
PR-URL: #36733
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen @ruyadorno
doc: change "it's" to "its" where necessary
70cd43c 
PR-URL: #36913
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@amcasey @ruyadorno
doc: update fs.l/statSync API history for throwIfNoEntry
82eccdd 
PR-URL: #36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@panva @ruyadorno
crypto: add keyObject.asymmetricKeyDetails for asymmetric keys
1149af6 
This API exposes key details. It is conceptually different from the
previously discussed keyObject.fields property since it does not give
access to information that could compromise the security of the key, and
the obtained information cannot be used to uniquely identify a key.

The intended purpose is to determine "security properties" of keys, e.g.
to generate a new key pair with the same parameters, or to decide
whether a key is secure enough.

closes #30045

PR-URL: #36188
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno
doc: wrap TOC in a <details> tag
f99b38f 
PR-URL: #36896
Fixes: #36885
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott @ruyadorno
doc: remove unnecessary contributing.md section
5cbf638 
Remove "How to Contribute in Issues". This is not Node.js-specific and
is likely to cause many readers to tune out. If we want to include this
kind of how-all-issue-trackers-are-intended-to-work information, let's
link to an external source. But I think it's OK to simply remove it.

Refs: nodejs/TSC#864 (comment)

PR-URL: #36891
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@tniessen @ruyadorno
crypto: fix randomInt bias
b7d8e61 
Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>

PR-URL: #36894
Refs: #34600
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson @ruyadorno
doc: update tls test to use better terminology
e73b107 
Given the effort to change the master branch to main,
this may make sense as part of removing other references
to the offending wording as well.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #36851
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mkrawczuk @ruyadorno
tls: use recently added matching SecureContext in default SNICallback
864b97b 
PR-URL: #36072
Fixes: #34110
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@miladfarca @ruyadorno
doc: add miladfarca to collaborators
80c84a1 
PR-URL: #36934
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
@panva @ruyadorno
doc: add alternative version links to the packages page
22e29cc 
PR-URL: #36915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@tniessen @ruyadorno
test: fix variable name for non-RSA keys
30b2aac 
PR-URL: #36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen @ruyadorno
test: check mustCall errors in test-fs-read-type
c2ec15a 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 @ruyadorno
http2: refactor to avoid unsafe array iteration
f5b8e7b 
PR-URL: #36700
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell @ruyadorno
doc: fixup typo in metadata entry
aa3bc74 
PR-URL: #36947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@iansu @ruyadorno
doc: add iansu to collaborators
5a9a07e 
PR-URL: #36951
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@aduh95 @ruyadorno
tools: add support for top-level await syntax in linter
8dc8adc 
PR-URL: #36911
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 @ruyadorno
doc: use ESM syntax for WASI example
707b973 
PR-URL: #36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@Trott @ruyadorno
doc: remove resolving-a-bug-report from contributing docs
7a79441 
This section isn't particularly useful in this context and contributes
to making the document longer and less effective. This is part of a
larger effort to make the contributing docs brief, informative, and
friendly.

Refs: nodejs/TSC#864 (comment)

PR-URL: #36905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott @ruyadorno
doc: remove issue template duplication from contributing docs
eaf378a 
The replicated issue template is out of date. There isn't much reason to
replicate it here anyway, so let's remove it and describe what the user
should do briefly.

PR-URL: #36908
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ronag @ruyadorno
http: cleanup ClientRequest oncreate
80051ab 
PR-URL: #36862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
@ronag @ruyadorno
http: refactor ClientRequest destroy
aa7243e 
PR-URL: #36863
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell @ruyadorno
test: fixup flaky test-crypto-x509 on windows
99c1590 
PR-URL: #36966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Lxxyx and others added 8 commits January 24, 2021 21:43
@Lxxyx @ruyadorno
tools,doc: list the stability status of each API
17bdcd9 
Fixes: #23723

PR-URL: #36223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ExE-Boss @ruyadorno
util: prefer Reflect.ownKeys(…)
f270417 
PR-URL: #36740
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joyeecheung @ruyadorno
src: use BaseObject::kInteralFieldCount in Blob
868d3b2 
Instead of hard-coding the field count.

PR-URL: #36991
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos @ruyadorno
deps: update ICU to 68.2
ef3a5f6 
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos @ruyadorno
doc: fix maintaining ICU guide
4b952d8 
PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos @ruyadorno
tools: cleanup old ICU version-specific fixes
6ef54bb 
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Lxxyx @ruyadorno
lib: refactor to use validateArray
8aeba3c 
PR-URL: #36982
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno
deps: upgrade npm to 7.4.3
e52e860 
PR-URL: #37018
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
ruyadorno added a commit that referenced this pull request Jan 25, 2021
@ruyadorno
2021-01-22, Version 15.7.0 (Current)
5fe188e 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
@ruyadorno
Copy link
Member Author

@tniessen I removed the mentioned commit to give you and the other collaborators some extra time to discuss, feel free to add the appropriate label in that original PR if you want to avoid having it landing in an upcoming release.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
MylesBorins
MylesBorins approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruyadorno
2021-01-26, Version 15.7.0 (Current)
2c0edbc 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 26, 2021 •
edited by ruyadorno
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/35742/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3702/
CITGM: https://ci.nodejs.org/job/citgm-smoker/2597/
CITGM (v15.x): https://ci.nodejs.org/job/citgm-smoker/2590/

@ruyadorno ruyadorno merged commit 2c0edbc into v15.x Jan 26, 2021
ruyadorno added a commit that referenced this pull request Jan 26, 2021
@ruyadorno
Working on v15.7.1
e1379a7 
PR-URL: #37020
ruyadorno added a commit that referenced this pull request Jan 26, 2021
@ruyadorno
2021-01-26, Version 15.7.0 (Current)
cef00ad 
PR-URL: #37020

Notable changes:

* buffer:
  * introduce Blob (James M Snell) [#36811](#36811)
  * add base64url encoding option (Filip Skokan) [#36952](#36952)
* doc:
  * add @iansu to collaborators (Ian Sutherland) [#36951](#36951)
  * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998)
  * add @miladfarca to collaborators (Milad Fa) [#36934](#36934)
* fs:
  * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190)
* http:
  * attach request as res.req (Ian Storm Taylor) [#36505](#36505)
  * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno added a commit to ruyadorno/nodejs.org that referenced this pull request Jan 26, 2021
@ruyadorno
Blog: v15.7.0 release post
88dc4ab 
Refs: nodejs/node#37020
@ruyadorno ruyadorno mentioned this pull request Jan 26, 2021
Merged
@ruyadorno ruyadorno deleted the v15.7.0-proposal branch January 26, 2021 16:26
ruyadorno added a commit to nodejs/nodejs.org that referenced this pull request Jan 26, 2021
@ruyadorno
Blog: v15.7.0 release post
6c20c57 
Refs: nodejs/node#37020
@targos targos added the release Issues and PRs related to Node.js releases. label Apr 11, 2021
@targos targos removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. meta Issues and PRs related to the general management of the project. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@richardlau richardlau richardlau approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.