Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update fs.l/statSync API history for throwIfNoEntry #36882

Closed
wants to merge 2 commits into from
Closed

chore: update fs.l/statSync API history for throwIfNoEntry #36882

wants to merge 2 commits into from

Conversation

amcasey
Copy link
Contributor

@amcasey amcasey commented Jan 12, 2021

As suggested here, now that there's a version number, the history in the API document can be updated to reflect this PR.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jan 12, 2021
@amcasey
Copy link
Contributor Author

amcasey commented Jan 12, 2021

FYI @merceyz

mscdex
mscdex reviewed Jan 12, 2021
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2021
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 12, 2021
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 12, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 12, 2021

@jasnell I removed the request-ci label because this is a doc-only change.

@jasnell
Copy link
Member

jasnell commented Jan 14, 2021

Landed in 8f32733

@jasnell jasnell closed this Jan 14, 2021
jasnell pushed a commit that referenced this pull request Jan 14, 2021
@amcasey @jasnell
doc: update fs.l/statSync API history for throwIfNoEntry
8f32733 
PR-URL: #36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 14, 2021
@amcasey @aduh95
doc: update fs.l/statSync API history for throwIfNoEntry
8b03585 
PR-URL: nodejs#36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Jan 14, 2021
Closed
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@amcasey @ruyadorno
doc: update fs.l/statSync API history for throwIfNoEntry
82eccdd 
PR-URL: #36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request Apr 26, 2021
@amcasey @targos
doc: update fs.l/statSync API history for throwIfNoEntry
5a3e12b 
PR-URL: #36882
Backport-PR-URL: #36921
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 26, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amcasey @aduh95 @jasnell @mscdex @targos @nodejs-github-bot