Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: replace push_back with emplace_back in debug_utils #36897

Conversation

RaisinTen
Copy link
Contributor

This prevents potential temporary object constructions.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 12, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This prevents potential temporary object constructions.

PR-URL: nodejs#36897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the src/replace-push_back-with-emplace_back-in-debug_utils branch from c7bfd1e to 4ae3135 Compare January 18, 2021 23:30
@aduh95
Copy link
Contributor

aduh95 commented Jan 18, 2021

Landed in 4ae3135

@aduh95 aduh95 merged commit 4ae3135 into nodejs:master Jan 18, 2021
@RaisinTen RaisinTen deleted the src/replace-push_back-with-emplace_back-in-debug_utils branch January 19, 2021 13:43
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
This prevents potential temporary object constructions.

PR-URL: #36897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
This prevents potential temporary object constructions.

PR-URL: #36897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
This prevents potential temporary object constructions.

PR-URL: #36897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants