doc: add romankl to collaborators #3725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
|
Aside: @romankl you should probably add yourself to the [mailmap] so that your old git info of |
|
LGTM |
|
🎉 ! |
|
This one-liner has a conflict 😮 |
|
@Fishrock123 should I include the update in this pr or wait till the next "update AUTHORs" pr ? |
|
@romankl rebase this branch onto latest master and force push the commit to this branch (to make sure). |
|
@romankl no that can be done in a separate commit. :) |
r-52
added a commit
that referenced
this pull request
Nov 10, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thank you!! Landed in 5235143 |
r-52
added a commit
that referenced
this pull request
Nov 11, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
r-52
added a commit
that referenced
this pull request
Nov 17, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
landed in v4.x-staging in a49dd89 |
r-52
added a commit
that referenced
this pull request
Dec 4, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Closed
r-52
added a commit
that referenced
this pull request
Dec 17, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
r-52
added a commit
that referenced
this pull request
Dec 23, 2015
PR-URL: #3725 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.