test: remove unnecessary V8 flag #37671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
fast-track? |
targos
approved these changes
Mar 9, 2021
4 tasks
lpinca
approved these changes
Mar 9, 2021
devsnek
approved these changes
Mar 9, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: nodejs#37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
|
Landed in 5247dc0 |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Mar 9, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: nodejs#37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Mar 15, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: nodejs#37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: #37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: #37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to remove the flag upstream.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582