test: remove unnecessary V8 flag #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/parallel/parallel.status
getentropy is only supported from libc 2.25, which is often not installed, but available in the sysroot headers. # Conflicts: # deps/openssl/openssl/crypto/rand/rand_unix.c
# Conflicts: # test/parallel/test-buffer-alloc.js # test/parallel/test-buffer-over-max-length.js
# Conflicts: # src/node_process_methods.cc # src/node_report.cc
The test is currently failing when updating V8's Node-CI
aduh95
force-pushed
the
v8-weak-ref-harmony
branch
from
348a427
to
f343037
Compare
|
@victorgomes PTAL so @aduh95 can land the upstream CL. |
|
Should I rebase that on top of https://github.com/v8/node/tree/node-ci-2021-03-09? |
Yeah, I think it should always be based on top of the most recent ci branch. |
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582 PR-URL: nodejs#37671 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
aduh95
force-pushed
the
v8-weak-ref-harmony
branch
from
f343037
to
98a2227
Compare
|
This was already merged on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs#37671
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes