doc: clarify duplicate headers in http.IncomingMessage #3810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
http
| In particular, for `content-type`, `content-length`, `user-agent`, `referer`, | ||
| `host`, `authorization`, `proxy-authorization`, `if-modified-since`, | ||
| `if-unmodified-since`, `from`, `location`, `max-forwards`, `retry-after`, | ||
| `etag`, `last-modified`, `age`, or `expires` the duplicate header values are |
There was a problem hiding this comment.
How about sorting it alphabetically?
bengl
force-pushed
the
dupedheadersdoc
branch
from
62c6a3d
to
d5660d3
Compare
|
@cjihrig @silverwind OK I changed it based on your comments. |
|
LGTM |
1 similar comment
|
LGTM |
cjihrig
pushed a commit
that referenced
this pull request
Nov 13, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Thanks! Landed in 4008961 |
Fishrock123
pushed a commit
that referenced
this pull request
Nov 17, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
landed in v4.x-staging as 0c5429a |
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
This commit documents how duplicate HTTP headers are handled. PR-URL: #3810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
headersobject onhttp.IncomingMessagedeals with duplicate headers in different ways depending on the header, and this wasn't documented (AFAIK), so here's a go at fixing that. The list is grabbed directly from source.Also happy to split the list out into a
<ul>if that's more desirable.