test: skip different params test for OpenSSL 3.x #38165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips the tests with different dh params as they are currently failing after the latest updated to OpenSSL 3.0.0-alpha14. I'll continue working and investigating the cause of this but it would be nice to get this merged so it does not fail the CI build.
nodejs-github-bot
added
needs-ci
|
This started failing with OpenSSL 3 alpha 14 (nodejs/build#2613 (comment)). 👍 to fast track to unbreak the CI. |
Fix lint issues.
richardlau
approved these changes
Apr 9, 2021
|
The failure in node-test-linux-linked-openssl300 is expected and fixed by #38164. |
danbev
added a commit
that referenced
this pull request
Apr 9, 2021
This skips the tests with different dh params as they are currently failing after the latest updated to OpenSSL 3.0.0-alpha14. I'll continue working and investigating the cause of this but it would be nice to get this merged so it does not fail the CI build. PR-URL: #38165 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in 269f513. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips the tests with different dh params as they are currently
failing after the latest updated to OpenSSL 3.0.0-alpha14.
I'll continue working and investigating the cause of this but it would
be nice to get this merged so it does not fail the CI build.