Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: consistent reference-style links #3845

Closed
wants to merge 1 commit into from
Closed

Conversation

bengl
Copy link
Member

@bengl bengl commented Nov 16, 2015

Moved all the URLs in API docs to the bottom of the files as reference link definitions.

This had already been done to some of the files and some had the reference link definitions halfway down the document due to some restructuring, so I thought it was worth fixing them all for consistency. This is the format specified in the relevant nodejs/docs guide.

Moved all the URLs in API docs to the bottom of the files as
reference-style links.
@thefourtheye thefourtheye added the doc Issues and PRs related to the documentations. label Nov 16, 2015
@tejasmanohar
Copy link

👍

@tflanagan
Copy link
Contributor

Thanks for fixing those! Looking through I can't find any others.

@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

LGTM! Thank you!

jasnell pushed a commit that referenced this pull request Nov 16, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 16, 2015

Landed in cd1123a ... fixed one typo in dgram.markdown (s/isa/is a)

@jasnell jasnell closed this Nov 16, 2015
Fishrock123 pushed a commit that referenced this pull request Nov 17, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

landed in v4.x-staging as ff992ff

Had to make minor changes to console.markdown as there is a semver major change on master not reflected in the v4.x docs

rvagg pushed a commit that referenced this pull request Dec 4, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Moved all the URLs in API docs to the bottom of the files as
reference-style links.

PR-URL: #3845
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants