Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo ( compability → compatibility ) #39044

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix typo ( compability → compatibility ) #39044

merged 1 commit into from
Jun 16, 2021

Conversation

houssemchebeb
Copy link
Contributor

Fixed typo

compability → compatibility

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 15, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 15, 2021
@cjihrig cjihrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @cjihrig. Please 👍 to approve.

@houssemchebeb @aduh95
tools: fix typo
0af0d1c 
compability -> compatibility

PR-URL: nodejs#39044
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Jun 16, 2021

Landed in 0af0d1c

@aduh95 aduh95 merged commit 0af0d1c into nodejs:master Jun 16, 2021
@houssemchebeb houssemchebeb deleted the fix-typo branch June 16, 2021 08:57
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@houssemchebeb @danielleadams
tools: fix typo
3ae2a0b 
compability -> compatibility

PR-URL: #39044
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
@richardlau
Copy link
Member

This was a typo in changes to support OpenSSL 3 which are not going to land on v14.x so marking dont-land-on-v14.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@houssemchebeb @aduh95 @richardlau @cjihrig @tniessen @Lxxyx