test: convert anonymous function to arrow function #39604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
himadriganguly
force-pushed
the
function-to-arrow
branch
from
ce8bdd2
to
7b4be06
Compare
himadriganguly
changed the title
gireeshpunathil
approved these changes
Jul 31, 2021
gireeshpunathil
added
the
request-ci
github-actions
bot
removed
the
request-ci
tniessen
approved these changes
Jul 31, 2021
|
Can anyone please guide me on why the test is failing so that I can fix it. Thank you all in advance. @gireeshpunathil @tniessen |
|
@himadriganguly The failure appears to be unrelated to your changes. I have restarted the failing tasks. Thank you for your contribution :) |
Thank you @tniessen. 👍 |
|
aix72-ppc64 appears to be having issues, cc @nodejs/build |
The IBM folks will need to take a look at that and probably won't get to it until Monday. However, there is at least one other AIX host, so I marked that one as offline. |
Lxxyx
approved these changes
Aug 2, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in ac621ff...fcc3910 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
PR-URL: #39604 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39604 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39604 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the anonymous function to the arrow function in the file test/parallel/test-http-write-head-2.js.
Checklist