-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: don't check the # of chunks in test-http-1.0 #3961
Conversation
As it can happen that the HTTP response is received in more than one TCP chunk.
I've never seen that test fail on OS X. What does the second chunk contain? |
@bnoordhuis It only happened once so I can't really say. I could reproduce it later on increasing the size of the response but that's not the same test. I'll run the tests some more time during the following days and come back with the results |
@bnoordhuis finally I could reproduce it.
The second chunk:
|
Huh, thanks. I figured out why it happens. There are a couple of places where the test does this: res.write('Hello, '); res._send('');
res.write('world!'); res._send(''); Which results in this:
But ends up getting read as a single packet, most of the time anyway.
I wonder if this isn't a performance issue (albeit a minor one) that we can fix by trying harder to coalesce writes. /cc @indutny - I know you were looking into a similar issue recently. Back to this PR, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/851/ |
Nah, this is not that much related to it. I think. |
LGTM |
1 similar comment
LGTM |
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Landed in dde2012, thanks Santiago. |
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: #3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: nodejs#3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
As it can happen that the HTTP response is received in more than
one TCP chunk.
It tries to fix the following failure I got in a
OS X
boxNot to sure if this is the correct fix as I don't really understand the reason to check the number of chunks in this test.