stream: be less eager with readable flag #4141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: nodejs#4125
|
LGTM if the CI is happy. |
|
LGTM. Is this a big enough change that we'd want to avoid it in LTS? |
|
+1 gotcha |
|
CI is all green except some unrelated Windows failures. |
|
Running the CI again since Windows wasn't working the last time, and I noticed the relevant test failing on Windows. |
|
A couple failures on Windows, but unrelated to this. Reiterating my LGTM |
mscdex
added a commit
that referenced
this pull request
Dec 4, 2015
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: #4125 PR-URL: #4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 2922188. |
mscdex
added a commit
that referenced
this pull request
Dec 5, 2015
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: #4125 PR-URL: #4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 8, 2015
Closed
|
Marking this lts-watch for now. It should land in v4.x-staging only if #4083 also lands |
|
Removing LTS tag as #4083 is currently not on LTS watch and labelled semver major |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: nodejs#4125 PR-URL: nodejs#4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in
child_process.This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF.
Fixes: #4125