-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove __builtin_bswap16 call #4290
Conversation
CI is fine. LGTM. |
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Not supported by apple-gcc and I'm not convinced it's worth adding more preprocessor hacks when it should be easy as pie for the compiler to to optimize the byteswap. If it doesn't, fix the compiler. Fixes: nodejs#4284 PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@bnoordhuis should this be backported to LTS? or is this making changes to stuff that never made it to 4.x |
@Fishrock123 we should add this to #4281 |
@thealphanerd Added lts-watch-v4.x label. Didn't see it in v4.x but it's still in v4.x-staging. |
Awesome thanks! I wonder if there is a smart way we can modify the meta data of commits landed on LTS to specify that other commits must land with them. I'm going to mull on this and likely open an issue about it if I can think of a solution |
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
#3410 will have to land into LTS before this commit can |
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: #4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove the unused and broken BITS_PER_LONG macro. Broken because x64 is the only 64 bits architecture where it produces the right result. PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Not supported by apple-gcc and I'm not convinced it's worth adding more preprocessor hacks when it should be easy as pie for the compiler to to optimize the byteswap. If it doesn't, fix the compiler. Fixes: nodejs#4284 PR-URL: nodejs#4290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Said builtins are not supported by older versions of apple-gcc, breaking the build on OS X 10.8. Fixes: nodejs#7618 Refs: nodejs#4290 Refs: nodejs#7157
Not supported by apple-gcc and I'm not convinced it's worth adding more
preprocessor hacks when it should be easy as pie for the compiler to
to optimize the byteswap. If it doesn't, fix the compiler.
Fixes: #4284
CI: https://ci.nodejs.org/job/node-test-pull-request/1002/