Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in http docs #43026

Merged
merged 1 commit into from
May 9, 2022
Merged

doc: use serial comma in http docs #43026

merged 1 commit into from
May 9, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 9, 2022

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 9, 2022
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit ec1c616 into nodejs:master May 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ec1c616

BethGriggs pushed a commit that referenced this pull request May 16, 2022
@tniessen @BethGriggs
doc: use serial comma in http docs
c988a0e 
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
doc: use serial comma in http docs
5f0006a 
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: use serial comma in http docs
e2a93f7 
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in http docs
f94ffa6 
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in http docs
14c8f46 
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in http docs
d715768 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @Trott @VoltrexKeyva