Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add STYLE_GUIDE (moved from nodejs/docs) #11321

Closed
wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Feb 12, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description:

Moves the STYLE_GUIDE.md from nodejs/docs to here (see linked PR: nodejs/docs#123):

Following discussion in #11286 (comment), I think it makes more sense to have the style guide in the core repo.

I originally planned to put it in doc/guides/, but on further thought I think it should be in the top level doc/ repo, as it applies to everything. Happy to be disagreed with on that though.

I think we should move it as is first, if any changes need to be made, we should make them in subsequent PRs.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 12, 2017
@thefourtheye
Copy link
Contributor

Would it be better to link this in CONTRIBUTING.md?

Also add a reference in CONTRIBUTING.md to it.
jasnell pushed a commit that referenced this pull request Feb 16, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 16, 2017

Landed in ca5215e

@jasnell jasnell closed this Feb 16, 2017
@gibfahn gibfahn deleted the styleguide branch February 17, 2017 01:39
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 20, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: nodejs#11321
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
jasnell pushed a commit that referenced this pull request Mar 7, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
Also add a reference in CONTRIBUTING.md to it.

PR-URL: #11321
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
tniessen added a commit to tniessen/node that referenced this pull request May 6, 2022
nodejs-github-bot pushed a commit that referenced this pull request May 6, 2022
Refs: #11321
Refs: #17384

PR-URL: #42989
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
tniessen added a commit to tniessen/node that referenced this pull request May 7, 2022
nodejs-github-bot pushed a commit that referenced this pull request May 8, 2022
Refs: #11321
Refs: #17384

PR-URL: #43001
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen added a commit to tniessen/node that referenced this pull request May 9, 2022
nodejs-github-bot pushed a commit that referenced this pull request May 9, 2022
Refs: #11321
Refs: #17384

PR-URL: #43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
Refs: #11321
Refs: #17384

PR-URL: #42989
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#42989
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43001
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43048
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43103
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43113
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43145
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43179
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43242
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43257
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43335
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43353
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43394
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43026
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43104
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43154
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
juanarbol pushed a commit that referenced this pull request Oct 10, 2022
Refs: #11321
Refs: #17384
PR-URL: #44482
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Oct 11, 2022
Refs: #11321
Refs: #17384
PR-URL: #44482
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
Refs: nodejs/node#11321
Refs: nodejs/node#17384
PR-URL: nodejs/node#44482
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
Refs: nodejs/node#11321
Refs: nodejs/node#17384
PR-URL: nodejs/node#44482
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tniessen added a commit to tniessen/node that referenced this pull request Mar 26, 2023
nodejs-github-bot pushed a commit that referenced this pull request Mar 27, 2023
Refs: #11321
Refs: #17384
PR-URL: #47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Refs: #11321
Refs: #17384
PR-URL: #47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
Refs: #11321
Refs: #17384
PR-URL: #47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Refs: #11321
Refs: #17384
PR-URL: #47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Refs: #11321
Refs: #17384
PR-URL: #47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants