Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in ESM docs #43322

Merged
merged 1 commit into from
Jun 5, 2022
Merged

doc: use serial comma in ESM docs #43322

merged 1 commit into from
Jun 5, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Jun 5, 2022

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jun 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 824c8b7 into nodejs:master Jun 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 824c8b7

italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
@tniessen @italojs
doc: use serial comma in ESM docs
b0626e9 
Refs: nodejs#11321
Refs: nodejs#17384

PR-URL: nodejs#43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@tniessen @danielleadams
doc: use serial comma in ESM docs
ccc88e5 
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@tniessen @danielleadams
doc: use serial comma in ESM docs
48b05ef 
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@tniessen @danielleadams
doc: use serial comma in ESM docs
8a4e1fa 
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in ESM docs
05aaa43 
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in ESM docs
f94d4ea 
Refs: #11321
Refs: #17384

PR-URL: #43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in ESM docs
763521e 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @JakobJingleheimer @VoltrexKeyva