Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in dgram docs #43191

Merged
merged 1 commit into from
May 23, 2022
Merged

doc: use serial comma in dgram docs #43191

merged 1 commit into from
May 23, 2022

Conversation

tniessen
Copy link
Member

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels May 23, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3b7241d into nodejs:master May 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3b7241d

bengl pushed a commit that referenced this pull request May 30, 2022
@tniessen @bengl
doc: use serial comma in dgram docs
598c1f1 
Refs: #11321
Refs: #17384

PR-URL: #43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bengl bengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: use serial comma in dgram docs
9bd50f6 
Refs: #11321
Refs: #17384

PR-URL: #43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in dgram docs
78d4a11 
Refs: #11321
Refs: #17384

PR-URL: #43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in dgram docs
1b97800 
Refs: #11321
Refs: #17384

PR-URL: #43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in dgram docs
5dd126a 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43191
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @Trott @lpinca @VoltrexKeyva