doc: remove outdated footnote (Python 2 --> 3 for V8 tests) #43105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.)
|
Review requested:
|
|
Oops, the XCode stuff is presumably still accurate on macOS. Maybe that should be kept... Edit: I pushed a commit to address this. (Should probably be squashed, but I know force pushing to open PRs is frowned upon...) |
Restore unintentionally deleted bit of the footnote. (I haven't checked whether just the "command line tools" are enough now. So it's safer to assume this part of the footnote is still accurate, than to assume the requirements have changed.)
Trott
reviewed
May 15, 2022
|
@nodejs/v8-update |
targos
approved these changes
May 15, 2022
Trott
added
the
commit-queue-squash
Trott
approved these changes
May 15, 2022
Trott
added
the
author ready
tniessen
approved these changes
May 15, 2022
RaisinTen
approved these changes
May 15, 2022
lpinca
approved these changes
May 15, 2022
gengjiawen
approved these changes
May 16, 2022
marsonya
approved these changes
May 16, 2022
JacksonTian
approved these changes
May 16, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5d9ad80 |
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.) PR-URL: #43105 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various Python 3 compatibility fixes were made in upstream V8,
and they have even dropped Python 2 compatibility in various scripts.
depot_tools, which bootstraps the V8 build, is also moving to Python 3.
As of Node v18.0.0-ish, this footnote is no-longer accurate.
(Running
make test-v8no-longer requires Python 2,and it won't work anymore if you don't have a copy of Python 3.)