Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove outdated footnote (Python 2 --> 3 for V8 tests) #43105

Merged
merged 3 commits into from
May 22, 2022
Merged

doc: remove outdated footnote (Python 2 --> 3 for V8 tests) #43105

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb5b286
doc: remove outdated footnote (Python 2 --> 3 for V8 tests)
DeeDeeG May 10, 2022
4ca2ca6
doc: restore the macOS-only note about needing full Xcode for V8 tests
DeeDeeG May 14, 2022
6f44a84
Update doc/contributing/maintaining-V8.md
Trott May 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions doc/contributing/maintaining-V8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,10 +407,8 @@ This would require some tooling to:
[^1]: Node.js 0.12 and older are intentionally omitted from this document
as their support has ended.

[^2]: The V8 tests still require Python 2. To run these tests locally, you can
run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
of this repository. On macOS, this also requires a full Xcode install,
not just the "command line tools" for Xcode.
[^2]: On macOS, The V8 tests require a full Xcode install, not just the "command
Trott marked this conversation as resolved.
Show resolved Hide resolved
line tools" for Xcode.

[ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar
[Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/
Expand Down