Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: use servername as agent key #4389

Closed
wants to merge 1 commit into from
Closed

https: use servername as agent key #4389

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Dec 22, 2015

https requests with different SNI values should not be sent over the
same connection, even if the host is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: #3940

@indutny
https: use servername as agent key
48864f0 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: nodejs#3940
@indutny indutny mentioned this pull request Dec 22, 2015
Closed
@indutny indutny added https Issues or PRs related to the https subsystem. lts-watch-v4.x labels Dec 22, 2015
@indutny
Copy link
Member Author

indutny commented Dec 22, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/1046/

@indutny
Copy link
Member Author

indutny commented Dec 22, 2015

cc @nodejs/crypto @nodejs/http @nodejs/collaborators

@bnoordhuis
Copy link
Member

LGTM but maybe write use servername in instead of use servername as?

@indutny
Copy link
Member Author

indutny commented Dec 22, 2015

Landed in 3213e5f, thank you!

@indutny indutny closed this Dec 22, 2015
@indutny indutny deleted the fix/gh-3940 branch December 22, 2015 18:51
indutny added a commit that referenced this pull request Dec 22, 2015
@indutny
https: use servername in agent key
3213e5f 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: #3940
PR-URL: #4389
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@indutny @Fishrock123
https: use servername in agent key
ca97e72 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: nodejs#3940
PR-URL: nodejs#4389
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@indutny
https: use servername in agent key
6924b6c 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: #3940
PR-URL: #4389
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@estliberitas estliberitas mentioned this pull request Jan 17, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@indutny
https: use servername in agent key
751fbd8 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: #3940
PR-URL: #4389
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
silverwind pushed a commit that referenced this pull request Jan 25, 2016
@estliberitas @silverwind
doc: add servername parameter docs
8ba5631 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit that referenced this pull request Jan 26, 2016
@estliberitas @rvagg
doc: add servername parameter docs
a1af6fc 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr pushed a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016
@estliberitas @benjamingr
doc: add servername parameter docs
d3ce9d3 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@estliberitas
doc: add servername parameter docs
d479686 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@estliberitas
doc: add servername parameter docs
1282663 
Add `servername` parameter docs for `https.request()` method.

Follows #4389

PR-URL: #4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@estliberitas
doc: add servername parameter docs
096a31e 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 13, 2016
@estliberitas @MylesBorins
doc: add servername parameter docs
c5ac66a 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@estliberitas
doc: add servername parameter docs
cb5986d 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@indutny
https: use servername in agent key
1002f87 
https requests with different SNI values should not be sent over the
same connection, even if the `host` is the same. Server may want to
present different certificate or route the incoming TLS connection
differently, depending on the received servername extension.

Fix: nodejs#3940
PR-URL: nodejs#4389
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@estliberitas
doc: add servername parameter docs
9be9463 
Add `servername` parameter docs for `https.request()` method.

Follows nodejs#4389

PR-URL: nodejs#4729
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@timotheeg timotheeg mentioned this pull request May 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indutny @bnoordhuis @MylesBorins