V4.2.5 proposal #4768
Merged
V4.2.5 proposal #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit the debug repl when repl emits 'exit' Refs: nodejs/node-v0.x-archive#5637 Fixes: nodejs/node-v0.x-archive#5631 PR-URL: #2369 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
IRC (general questions): irc.freenode.net #node.js IRC (node core development): irc.freenode.net #node-dev PR-URL: #2743 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Because Node modules are wrapped, errors on the first line of a file leak the wrapper to the user and report the wrong column number. This commit adds a line break to the module wrapper so that the first line is treated the same as all other lines. To compensate for the additional line, a line offset of -1 is also applied to errors. Fixes: #2860 PR-URL: #2867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This PR is the first step enabling support for native modules
for AIX. The main issue is that unlike linux where all
symbols within the Node executable are available to the shared
library for a native module (npm), on AIX the symbols must
be explicitly exported. In addition, when the shared library is
built it must be linked using a list of the available symbols.
This patch covers the changes need to:
1) Export the symbols when building the node executable
2) Generate the file listing the symbols that can be used when
building the shared library.
For AIX, it breaks the build process into 2 steps. The first builds
a static library and then generates a node.exp file which contains
the symbols from that library. The second builds the node executable
and uses the node.exp file to specify which symbols should be
exported. In addition, it save the node.exp file so that it can
later be used in the creation of the shared library when building
a native module.
The following additional steps will be required in dependent projects
to fully enable AIX for native modules and are being worked
separately:
- Updates to node-gyp to use node.exp when creating the
shared library for a native module
- Fixes to gyp related to copying files as covered in
https://codereview.chromium.org/1368133002/patch/1/10001
- Pulling in updated gyp versions to Node and node-gyp
- Pulling latest libuv
These changes were done to minimize the change to other platforms
by working within the existing structure to add the 2 step process
for AIX without changing the process for other platforms.
PR-URL: #3114
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
As per the `prefer-const` eslint rule, few instances of `let` have been identified to be better with `const`. This patch updates all those instances. Refer: #3118 PR-URL: #3152 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Description from: http://eslint.org/docs/rules/prefer-const.html If a variable is never modified, using the `const` declaration is better. `const` declaration tells readers, "this variable is never modified," reducing cognitive load and improving maintainability. Refer: #3118 PR-URL: #3152 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #3235 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3364
These new checks are similar to the one introduced in 089d688, but for other types of objects. Specifically, if an object was created in a different context, the constructor object will not be the same as the constructor object in the current context, so we have to compare constructor names instead. PR-URL: #3385 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Implement a crude TAP13 writer for cpplint. Does its job and not much else. Only supports writing TAP output to file, not vs7 or emacs formats. PR-URL: #3448 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Only enforce that the init callback is passed to setupHooks(). The remaining hooks can be optionally passed. Throw if async_wrap.enable() runs before setting the init callback or if setupHooks() is called while async wrap is enabled. Add test to verify calls throw appropriately. PR-URL: #3461 Reviewed-By: Fedor Indutny <fedor@indutny.com>
New instances of AsyncWrap are automatically assigned a unique id. The value will be used in future commits to communicate additional information via the async hooks. While the largest value we can reliably communicate to JS is 2^53, even if a new AsyncWrap is created every 100ns the uid won't reach its end for 28.5 years. PR-URL: #3461 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Call a user's callback to notify that the handle has been destroyed. Only pass the id of the AsyncWrap instance since the object no longer exists. The object that's being destructed should never be inspected within the callback or any time afterward. This commit make a breaking change. The init callback will now be passed arguments in the order of provider, id, parent. PR-URL: #3461 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3463
Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #3480
PR-URL: #3576 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #3661 Reviewed-By: James M Snell <jasnell@gmail.com>
The current implementation of tests for strings with length at or exceeding kStringMaxLength allocate a temporary buffer inside a try block to skip the test if there is insufficient memory. This commit adds an invocation of the garbage collector after the temporary buffer is allocated so that memory is freed for later allocations. Change the corresponding catch block to rethrow the original exception instead of asserting the exception message to provide more information about the exception. Add an additional check before trying to allocate memory to immediately skip the test on machines with insufficient total memory. PR-URL: #3697 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
In preparation for a lint rule that will enforce `throw new Error()` over `throw Error()`, fix the handful of instances in the code that use `throw Error()`. PR-URL: #3714 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add linting rule requiring `throw new Error()` over `throw Error()`. PR-URL: #3714 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
As per the OpenSSL User Guide, it is possible to use the FIPSDIR environment variable to specify a custom install path for the validated cryptographic module. PR-URL: #3752 Reviewed-By: Michael Dawsson <michael_dawson@ca.ibm.com> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: Fedor Indutny <fedor@indutny.com>
FIPS 140-2 disallows use of MD5, which is used to derive the initialization vector and key for createCipher(). Modify all tests to expect exceptions in FIPS mode when disallowed API is used, or to avoid testing such API in FIPS Mode. PR-URL: #3754 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: James M Snell <jasnell@gmail.com>
Previously, this test was not supported on OS X. This change makes sure that it is no longer skipped. PR-URL: #3901 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #3912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit moves the deprecation message for fs.existsSync() above the function description, making message placement uniform across the documentation. PR-URL: #3942 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`options` is already a param of the function. PR-URL: #3943 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
@thealphanerd can we look at adding 7b45163 as well? It should be rather unobtrusive and gives us the option of getting tap output from linting as well. Need to look closer at that arm fail (or if @rvagg beats me to it) |
MylesBorins
force-pushed
the
v4.2.5-propose
branch
from
7026d38 to
2b6386a
Compare
|
@jbergstroem it is already in there --> f413fae I added it to the notable changes 😄 |
|
@thealphanerd ah! my bad :) |
|
pi1 failures look like hw problems, both failed on the same host, I'm going to do an update and reboot the pi1s and rerun |
|
@nodejs/build: We lost 3 pi1's in that restart, but not the one that was causing problems. We already have one pi2 out of action so now I have 4 that I need to fix, hopefully just disk problems. They're not exactly in datacenter conditions and today has been one of the hottest days they've experienced to date. Running arm-fanned again here: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1200/ |
|
Got 2 of them back up! network problems, halted on booting with NFS, had to restart CI: https://ci.nodejs.org/job/node-test-commit-arm-fanned/1203/ |
|
👍 |
|
Thank you for picking this up @thealphanerd , I appreciate it. Initial review looks good. If CI is green and CITGM looks good, ship it! LGTM |
MylesBorins
force-pushed
the
v4.2.5-propose
branch
from
2b6386a to
34042df
Compare
MylesBorins
force-pushed
the
v4.2.5-propose
branch
from
34042df to
361decf
Compare
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) #4166 * build - add "--partly-static" build options (Super Zheng) #4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) #4013 - display error message when loading directory (Prince J Wesley) #4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) #3988 PR-URL: #4768
MylesBorins
force-pushed
the
v4.2.5-propose
branch
from
361decf to
e6ca04c
Compare
|
All green, moving forward with the release Release CI job: https://ci.nodejs.org/job/iojs+release/360/ |
|
Woo!
|
|
Looks like the builds all worked. ppcbe-fedora has not started the build and is holding up the job from finishing. @jbergstroem informed me that the machine is down and require's external support to get working. I am going to promote this build w/o ppcbe which we can add once the machine is back up and running |
|
@thealphanerd if it were online it would just be shortcutting and not building anyway. Just go ahead with the assumption that it's all finished. |
|
thanks @rvagg that's all the confirmation I needed :D |
PR-URL: #4768
MylesBorins
pushed a commit
that referenced
this pull request
Jan 20, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) #4166 * build - add "--partly-static" build options (Super Zheng) #4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) #4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) #4013 - display error message when loading directory (Prince J Wesley) #4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) #3988 PR-URL: #4768
pesho
added a commit
to pesho/docker-official-images
that referenced
this pull request
Jan 20, 2016
Related: nodejs/docker-node#89 Related: nodejs/node#4768 Related: nodejs/docker-node#85
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) nodejs#4166 * build - add "--partly-static" build options (Super Zheng) nodejs#4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) nodejs#4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) nodejs#4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) nodejs#4013 - display error message when loading directory (Prince J Wesley) nodejs#4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) nodejs#3988 PR-URL: nodejs#4768
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
Related: nodejs/docker-node#89 Related: nodejs/node#4768 Related: nodejs/docker-node#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
Known issues
beforeExitare still to be resolved. See #1264.dns.setServers()while a DNS query is in progress can cause the process to crash on a failed assertion. #894url.resolvemay transfer the auth portion of the url when resolving between two full hosts, see #1435.Commits
87181cd74c] - assert: accommodate ES6 classes that extend Error (Rich Trott) #4166901172a783] - assert: typed array deepequal performance fix (Claudio Rodriguez) #433055336810ee] - async_wrap: call callback in destructor (Trevor Norris) #3461a8b45e9e96] - async_wrap: new instances get uid (Trevor Norris) #346149f16d77c4] - async_wrap: allow some hooks to be optional (Trevor Norris) #346144ee33f945] - buffer: refactor create buffer (Jackson Tian) #4340138d004ac0] - buffer: faster case for create Buffer from new Buffer(0) (Jackson Tian) #4326c6dc2a1609] - buffer: Prevent Buffer constructor deopt (Bryce Baril) #4158a320045e68] - buffer: default to UTF8 in byteLength() (Tom Gallacher) #4010c5f71ac771] - build: add "--partly-static" build options (Super Zheng) #4152e6c25335ea] - build: omit -gline-tables-only for --enable-asan (Ben Noordhuis) #368080b4ba286c] - build: Updates for AIX npm support - part 1 (Michael Dawson) #311435e32985ca] - child_process: guard against race condition (Rich Trott) #441848564204f0] - child_process: flush consuming streams (Dave) #4071481d59a74c] - configure: fix arm vfpv2 (Jörg Krause) #4203d19da6638d] - crypto: load PFX chain the same way as regular one (Fedor Indutny) #4165b8e75de1f3] - crypto: fix native module compilation with FIPS (Stefan Budeanu) #4023b7c3fb7f75] - crypto: disable crypto.createCipher in FIPS mode (Stefan Budeanu) #375431b4091a1e] - debugger: also exit when the repl emits 'exit' (Felix Böhm) #23699baa5618f5] - deps: backport 066747e from upstream V8 (Ali Ijaz Sheikh) #4655c3a9d8a62e] - deps: backport 200315c from V8 upstream (Vladimir Kurchatkin) #41281ebb0c0fdf] - deps: upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) #4276253fe3e7c8] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #30518c2b65ad82] - doc: clarify protocol default in http.request() (cjihrig) #471433e72e135f] - doc: update links to use https where possible (jpersson) #40545f4aa79410] - doc: clarify explanation of first stream section (Vitor Cortez) #4234295ca5bfb2] - doc: add branch-diff example to releases.md (Myles Borins) #463618f5cd8710] - doc: update stylesheet to match frontpage (Roman Reiss) #46212f40715f08] - doc: adds usage of readline line-by-line parsing (Robert Jefe Lindstaedt) #46095b45a464ee] - doc: document http's server.listen return value (Sequoia McDowell) #4590bd31740339] - doc: label http.IncomingMessage as a Class (Sequoia McDowell) #4589bcd2cbbb93] - doc: fix description about the latest-codename (Minwoo Jung) #45830b12bcb35d] - doc: add Evan Lucas to Release Team (Evan Lucas) #4579e20b1f6f10] - doc: add Myles Borins to Release Team (Myles Borins) #457854977e63eb] - doc: add missing backtick for readline (Brian White) #45495d6bed895c] - doc: bring releases.md up to date (cjihrig) #45400cd2252e85] - doc: fix numbering in stream.markdown (Richard Sun) #45388574d91f27] - doc: stronger suggestion for userland assert (Wyatt Preul) #4535a7bcf8b84d] - doc: close backtick in process.title description (Dave) #45340ceb3148b0] - doc: improvements to events.markdown copy (James M Snell) #4468bf56d509b9] - doc: explain ClientRequest#setTimeout time unit (Ben Ripkens) #4458d927c51be3] - doc: improvements to errors.markdown copy (James M Snell) #4454ceea6df581] - doc: improvements to dns.markdown copy (James M Snell) #4449506f2f8ed1] - doc: add anchors for _transform _flush _writev in stream.markdown (iamchenxin) #444874bcad0b78] - doc: improvements to dgram.markdown copy (James M Snell) #4437e244d560c9] - doc: improvements to debugger.markdown copy (James M Snell) #4436df7e1281a5] - doc: improvements to console.markdown copy (James M Snell) #4428abb17cc6c1] - doc: fix spelling error in lib/url.js comment (Nik Nyby) #4390823269db2d] - doc: improve assert.markdown copy (James M Snell) #43602b1804f6cb] - doc: copyedit releases.md (Rich Trott) #43842b142fd876] - doc: catch the WORKING_GROUPS.md bootstrap docs up to date (James M Snell) #4367ed87873de3] - doc: fix link in addons.markdown (Nicholas Young) #4331fe693b7a4f] - doc: Typo in buffer.markdown referencing buf.write() (chrisjohn404) #4324764df2166e] - doc: document the cache parameter for fs.realpathSync (Jackson Tian) #428561f91b2f29] - doc: fix, modernize examples in docs (James M Snell) #4282d87ad302ce] - doc: clarify error events in HTTP module documentation (Lenny Markus) #42757983577e41] - doc: fix improper http.get sample code (Hideki Yamamura) #42636c30d087e5] - doc: Fixing broken links to the v8 wiki (Tom Gallacher) #4241cf214e56e4] - doc: move description of 'equals' method to right place (janriemer) #4227fb8e8dbb92] - doc: copyedit console doc (Rich Trott) #42254ccf04c229] - doc: add mcollina to collaborators (Matteo Collina) #422059654c21d4] - doc: add rmg to collaborators (Ryan Graham) #4219bfe1a6bd2b] - doc: add calvinmetcalf to collaborators (Calvin Metcalf) #42185140c404ae] - doc: harmonize description ofcaargument (Ben Noordhuis) #42132e642051cf] - doc: copyedit child_process doc (Rich Trott) #41887920f8dbde] - doc: copyedit buffer doc (Rich Trott) #4187c35a409cbe] - doc: clarify assert.fail doc (Rich Trott) #41866235fdf72e] - doc: copyedit addons doc (Rich Trott) #4185990e7ff93e] - doc: update AUTHORS list (Rod Vagg) #41838d676ef55e] - doc: change references from node to Node.js (Roman Klauke) #41771c34b139a2] - doc: add brief Node.js overview to README (wurde) #417427b9b72ab0] - doc: add iarna to collaborators (Rebecca Turner) #4144683d8dd564] - doc: add JungMinu to collaborators (Minwoo Jung) #414317b06dfa94] - doc: add zkat to collaborators (Kat Marchán) #414239364c4c72] - doc: improve child_process.markdown wording (yorkie) #4138abe452835f] - doc: url.format - true slash postfix behaviour (fansworld-claudio) #41196dd375cfe2] - doc: document backlog for server.listen() variants (Jan Schär) #4025b71a3b363a] - doc: fixup socket.remoteAddress (Arthur Gautier) #4198e2fe214857] - doc: add links and backticks around names (jpersson) #4054bb158f8aed] - doc: s/node.js/Node.js in readme (Rod Vagg) #3998f55491ad47] - doc: move fs.existsSync() deprecation message (Martin Forsberg) #39428c5b847f5b] - doc: Describe FIPSDIR environment variable (Stefan Budeanu) #375270c95ea0e5] - doc: add warning about Windows process groups (Roman Klauke) #368146c59b7256] - doc: add CTC meeting minutes 2015-10-28 (Rod Vagg) #36617ffd299a1d] - doc: add final full stop in CONTRIBUTING.md (Emily Aviva Kapor-Mater) #35761f78bff7ce] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #34802e623ff024] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463b9c69964bb] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364f31d23c724] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235ae8e3af178] - doc: update irc channels: #node.js and #node-dev (Nelson Pecora) #2743830caeb1bd] - doc, test: symbols as event names (Bryan English) #415182cbfcdcbe] - docs: update gpg key for Myles Borins (Myles Borins) #465750b72aa5a3] - docs: fix npm command in releases.md (Myles Borins) #46565bf56882e1] - fs,doc: usetargetinstead ofdestination(yorkie) #391241fcda840c] - http: useself.keepAliveinstead ofself.options.keepAlive(Damian Schenkelman) #44073ff237333d] - http: Remove an unnecessary assignment (Bo Borgerson) #432339dc054572] - http: remove excess calls to removeSocket (Dave) #4172751fbd84dd] - https: useservernamein agent key (Fedor Indutny) #43897a1a0a0055] - lib: remove unused modules (Rich Trott) #46833d81ea99bb] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #31528a9869eeab] - module: fix column offsets in errors (Tristian Flanagan) #28670ae90ecd3d] - module,repl: remove repl require() hack (Ben Noordhuis) #4026a7367fdc1e] - net: small code cleanup (Jan Schär) #394303e9495cc2] - node: remove unused variables in AppendExceptionLine (Yazhong Liu) #426406113b8711] - node: s/doNTCallbackX/nextTickCallbackWithXArgs/ (Rod Vagg) #41678ce6843fe4] - os: fix crash in GetInterfaceAddresses (Martin Bark) #427253dcbb6aa4] - repl: remove unused function (Rich Trott)db0e906fc1] - repl: Fixed node repl history edge case. (Mudit Ameta) #41089855fab05f] - repl: use String#repeat instead of Array#join (Evan Lucas) #390041882e4077] - repl: fix require('3rdparty') regression (Ben Noordhuis) #421593afc39d4a] - repl: attach location info to syntax errors (cjihrig) #4013d4806675a6] - repl: display error message when loading directory (Prince J Wesley) #41703080bdc7d7] - src: define Is* util functions with macros (cjihrig) #41182b8a32a13b] - src: refactor vcbuild configure args creation (Rod Vagg) #3399d47f6ba768] - src: fix deprecation message for ErrnoException (Martin von Gagern) #42695ba08fbf76] - src: fix line numbers on core errors (cjihrig) #425470974e9362] - src: use GetCurrentProcessId() for process.pid (Ben Noordhuis) #4163c96eca164f] - src: don't print garbage errors (cjihrig) #4112f61412c753] - test: mark test-debug-no-context is flaky (Rich Trott) #442146d8c93ed2] - test: don't use cwd for relative path (Johan Bergström) #4477b6124ea39c] - test: write to tmp dir rather than fixture dir (Rich Trott) #4489350fa664bb] - test: don't assume a certain folder structure (Johan Bergström) #33256b2ef0efac] - test: make temp path customizable (Johan Bergström) #3325f1837703a9] - test: remove unused vars from parallel tests (Rich Trott) #4511b4964b099a] - test: remove unused variables form http tests (Rich Trott) #44220d5a508dfb] - test: extend timeout in Debug mode (Rich Trott) #44316e4598d5da] - test: remove unused variables from TLS tests (Rich Trott) #44247b1aa045a0] - test: remove unused variables from HTTPS tests (Rich Trott) #4426da9e5c1b01] - test: remove unused variables from net tests (Rich Trott) #443013241bd24b] - test: remove unused vars in ChildProcess tests (Rich Trott) #44252f4538ddda] - test: remove unused vars (Rich Trott) #4536dffe83ccd6] - test: remove unused modules (Rich Trott) #4684c4eeb88ba1] - test: fix flaky cluster-disconnect-race (Brian White) #44577caf87bf6c] - test: fix flaky test-http-agent-keepalive (Rich Trott) #452425c41d084d] - test: remove flaky designations for tests (Rich Trott) #4519b8f097ece2] - test: fix flaky streams test (Rich Trott) #4516c24fa1437c] - test: inherit JOBS from environment (Johan Bergström) #44957dc90e9e7f] - test: remove time check (Rich Trott) #44947ca3c6c388] - test: refactor test-fs-empty-readStream (Rich Trott) #4490610727dea7] - test: clarify role of domains in test (Rich Trott) #44741ae0e355b9] - test: improve assert message (Rich Trott) #4461e70c88df56] - test: remove unused assert module imports (Rich Trott) #4438c77fc71f9b] - test: remove unused var from test-assert.js (Rich Trott) #4405f613b3033f] - test: add test-domain-exit-dispose-again back (Julien Gilli) #4256f5bfacd858] - test: remove unusedutilimports (Rich Trott) #4562d795301025] - test: remove unnecessary assignments (Rich Trott) #4563acc3d66934] - test: move ArrayStream to common (cjihrig) #40276c0021361c] - test: refactor test-net-connect-options-ipv6 (Rich Trott) #439529804e00ad] - test: use platformTimeout() in more places (Brian White) #4387761af37d0e] - test: fix race condition in test-http-client-onerror (Devin Nakamura) #4346980852165f] - test: fix flaky test-net-error-twice (Brian White) #43421bc44e79d3] - test: try other ipv6 localhost alternatives (Brian White) #432544dbe15640] - test: fix debug-port-cluster flakiness (Ben Noordhuis) #431073e781172b] - test: add test for tls.parseCertString (Evan Lucas) #428315c295a21b] - test: use regular timeout times for ARMv8 (Jeremiah Senkpiel) #4248fd250b8fab] - test: parallelize test-repl-persistent-history (Jeremiah Senkpiel) #42479a0f156e5a] - test: fix domain-top-level-error-handler-throw (Santiago Gimeno) #43646bc1b1c259] - test: don't assume openssl s_client supports -ssl3 (Ben Noordhuis) #4204d00b9fc66f] - test: fix tls-inception flakiness (Santiago Gimeno) #4195c41b280a2b] - test: fix tls-inception (Santiago Gimeno) #41956f4ab1d1ab] - test: mark test-cluster-shared-leak flaky (Rich Trott) #416290498e2a68] - test: skip long path tests on non-Windows (Rafał Pocztarski) #4116c9100d78f3] - test: fix flaky test-net-socket-local-address (Rich Trott) #4109ac939d51d9] - test: improve cluster-disconnect-handles test (Brian White) #408422ba1b4115] - test: eliminate multicast test FreeBSD flakiness (Rich Trott) #40422ee7853bb7] - test: fix http-many-ended-pipelines flakiness (Santiago Gimeno) #4041a77dcfec06] - test: use platform-based timeout for reliability (Rich Trott) #40153f0ff879cf] - test: fix time resolution constraint (Gireesh Punathil) #398122b88e1c48] - test: add TAP diagnostic message for retried tests (Rich Trott) #396022d2887b1c] - test: add OS X to module loading error test (Evan Lucas) #3901e2141cb75e] - test: skip instead of fail when mem constrained (Michael Cornacchia) #3697166523d0ed] - test: fix race condition in unrefd interval test (Michael Cornacchia) #355086b47e8dc0] - timers: optimize callback call: bind -> arrow (Andrei Sedoi) #40384d37472ea7] - tls_wrap: clear errors on return (Fedor Indutny) #47095b695d0343] - tls_wrap: inherit from theAsyncWrapfirst (Fedor Indutny) #42680efc35e6d8] - tls_wrap: slice buffer properly inClearOut(Fedor Indutny) #4184628cb8657c] - tools: add .editorconfig (ronkorving) #299369fef19624] - tools: implement no-unused-vars for eslint (Rich Trott) #45363ee16706f2] - tools: enforcethrow new Error()with lint rule (Rich Trott) #371432801de4ef] - tools: Usethrow new Error()consistently (Rich Trott) #3714f413fae0cd] - tools: add tap output to cpplint (Johan Bergström) #3448efa30dd2f0] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #3152dd0c925896] - udp: remove a needless instanceof Buffer check (ronkorving) #4301f4414102ed] - util: faster arrayToHash (Jackson Tian)b421119984] - util: determine object types in C++ (cjihrig) #41006a7c9d9293] - util: move .decorateErrorStack to internal/util (Ben Noordhuis) #4026422a865d46] - util: add decorateErrorStack() (cjihrig) #40132d5380ea25] - util: fix constructor/instanceof checks (Brian White) #33851bf84b9d41] - util,src: allow lookup of hidden values (cjihrig) #3988