Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: debug-no-context is flaky #4421

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 25, 2015

test-debug-no-context is flaky on Windows. Mark as such.

Ref: #4343

R=@mscdex

@mscdex
Copy link
Contributor

mscdex commented Dec 25, 2015

LGTM

@Trott
Copy link
Member Author

Trott commented Dec 25, 2015

test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott Trott force-pushed the test-debug-no-context-flaky branch from f5c9c6b to 21610bb Compare December 25, 2015 17:26
@mscdex mscdex added debugger test Issues and PRs related to the tests. labels Dec 25, 2015
@mscdex
Copy link
Contributor

mscdex commented Dec 25, 2015

All green! \o/

@Trott
Copy link
Member Author

Trott commented Dec 25, 2015

It's a Christmas miracle.

@MylesBorins
Copy link
Contributor

Did this actually just happen???????

Trott added a commit to Trott/io.js that referenced this pull request Dec 28, 2015
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott
Copy link
Member Author

Trott commented Dec 28, 2015

Landed in d09c447

@Trott Trott closed this Dec 28, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
Trott added a commit to Trott/io.js that referenced this pull request Jan 17, 2016
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
jasnell pushed a commit that referenced this pull request Jan 18, 2016
test-debug-no-context is flaky on Windows. Mark as such.

Ref: #4343
PR-URL: #4421
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
test-debug-no-context is flaky on Windows. Mark as such.

Ref: #4343
PR-URL: #4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test-debug-no-context is flaky on Windows. Mark as such.

Ref: nodejs#4343
PR-URL: nodejs#4421
Reviewed-By: Brian White <mscdex@mscdex.net>
@Trott Trott deleted the test-debug-no-context-flaky branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants