Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: small code cleanup #3943

Closed
wants to merge 1 commit into from
Closed

net: small code cleanup #3943

wants to merge 1 commit into from

Conversation

jscissr
Copy link
Contributor

@jscissr jscissr commented Nov 20, 2015

options is already a param of the function.

@jscissr
net: small code cleanup
f8124d1 
`options` is already a param of the function.
@cjihrig
Copy link
Contributor

cjihrig commented Nov 20, 2015

LGTM. This is likely left over from when Server() used arguments.

@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Nov 20, 2015

LGTM

@evanlucas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/799/

@MylesBorins
Copy link
Contributor

LGTM

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Nov 20, 2015
jasnell pushed a commit that referenced this pull request Nov 20, 2015
@jscissr @jasnell
net: small code cleanup
9472a0c 
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 20, 2015

Landed in 9472a0c

@jasnell jasnell closed this Nov 20, 2015
@jscissr jscissr deleted the patch-1 branch November 21, 2015 00:34
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
rvagg pushed a commit that referenced this pull request Dec 5, 2015
@jscissr @rvagg
net: small code cleanup
12754c5 
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
@jscissr
net: small code cleanup
80d8529 
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@jscissr
net: small code cleanup
a7367fd 
`options` is already a param of the function.

PR-URL: #3943
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jscissr @cjihrig @evanlucas @targos @MylesBorins @jasnell @mscdex