test: remove unused variables from HTTPS tests #4426
Conversation
Trott
added
https
|
(sorry for the slight delay in testing; redeploying machines so ccache is cold) |
|
Is the failed test on windows (tick processor) a known issue/documented somewhere? Obviously unrelated here. |
|
LGTM |
|
Unfortunately, that seemingly unrelated test failure looks like a new one. Running a stress test to see if it's easily reproducible: https://ci.nodejs.org/job/node-stress-single-test/208/nodes=win-vs2013/console And just for good measure, re-running CI to confirm that it's not some mysterious "oh yeah, if you change a test over here, it affects a test over there" kind of thing that will definitely make me question everything I think I know. Tell me, Node.js CI, is my entire existence a lie?! https://ci.nodejs.org/job/node-test-commit/1534/ |
|
Added an issue for the failed test: #4427 |
|
One more var removed, re-running CI: https://ci.nodejs.org/job/node-test-commit/1537/ |
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in fd395ba |
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
PR-URL: #4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
PR-URL: nodejs#4426 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
No description provided.