Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't assume openssl s_client supports -ssl3 #4204

Merged
merged 1 commit into from
Dec 9, 2015
Merged

test: don't assume openssl s_client supports -ssl3 #4204

merged 1 commit into from
Dec 9, 2015

Conversation

bnoordhuis
Copy link
Member

Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927

R=@Trott? /cc @kapouer

CI: https://ci.nodejs.org/job/node-test-pull-request/963/

@bnoordhuis bnoordhuis added the test Issues and PRs related to the tests. label Dec 8, 2015
@bnoordhuis bnoordhuis mentioned this pull request Dec 8, 2015
Closed
@Trott
Copy link
Member

Trott commented Dec 9, 2015

LGTM if CI and @kapouer are happy with it

CI: https://ci.nodejs.org/job/node-test-commit/1397/

@bnoordhuis
test: don't assume openssl s_client supports -ssl3
1e89830 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: nodejs#3927
PR-URL: nodejs#4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
@bnoordhuis bnoordhuis closed this Dec 9, 2015
@bnoordhuis bnoordhuis deleted the fix3927 branch December 9, 2015 19:17
@bnoordhuis bnoordhuis merged commit 1e89830 into nodejs:master Dec 9, 2015
@bnoordhuis
Copy link
Member Author

Thanks, landed in 1e89830. One failure which is tracked in #4206.

@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
Closed
bnoordhuis added a commit that referenced this pull request Dec 15, 2015
@bnoordhuis @cjihrig
test: don't assume openssl s_client supports -ssl3
42b7f1a 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
bnoordhuis added a commit that referenced this pull request Dec 30, 2015
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
6a0ec14 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
6bc1b1c 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: #3927
PR-URL: #4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@bnoordhuis
test: don't assume openssl s_client supports -ssl3
146e10b 
Scan the child process's stderr for an 'unknown flag' error message and
mark the test as skipped if found.

Fixes: nodejs#3927
PR-URL: nodejs#4204
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Mar 18, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 19, 2020
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 1, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @Trott @MylesBorins