doc: improvements to debugger.markdown copy #4436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| simple [TCP protocol][]. Node.js has a built-in client for this debugger. To | ||
| use this, start Node.js with the `debug` argument; a prompt will appear: | ||
| V8 includes a full-featured debugging utility that is accessible out-of-process | ||
| via a simple [TCP protocol][]. Node.js provides a built-in client for this |
There was a problem hiding this comment.
Maybe this should be "TCP based protocol".
There was a problem hiding this comment.
Nit: remove simple
Nit: If you do go with TCP based protocol, hyphenate: TCP-based protocol
|
LGTM with comments. |
|
LGTM |
1 similar comment
|
LGTM |
| simple [TCP protocol][]. Node.js has a built-in client for this debugger. To | ||
| use this, start Node.js with the `debug` argument; a prompt will appear: | ||
| V8 includes a full-featured debugging utility that is accessible out-of-process | ||
| via a simple [TCP-based protocol][]. Node.js provides a built-in client for this |
There was a problem hiding this comment.
Technically speaking that's no longer true; the TCP endpoint is provided by node, V8 only provides a programmatic API.
|
LGTM with a nit. |
General improvements to debugger.markdown
jasnell
force-pushed
the
doc-debugger-improvements
branch
from
06a4444
to
1db92dd
Compare
|
@bnoordhuis ... nits addressed. I just took out the references to it being V8's debugger. |
jasnell
added a commit
that referenced
this pull request
Dec 30, 2015
General improvements to debugger.markdown PR-URL: #4436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 1a004f1 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
General improvements to debugger.markdown PR-URL: nodejs#4436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
added a commit
that referenced
this pull request
Jan 7, 2016
General improvements to debugger.markdown PR-URL: #4436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
General improvements to debugger.markdown PR-URL: #4436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
General improvements to debugger.markdown PR-URL: nodejs#4436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements to debugger.markdown