Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: parallelize test-repl-persistent-history #4247

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

Fishrock123
Copy link
Contributor

It already uses common.tmpdir, at the time I didn't understand that using that made it parallel-ready.

cc @Trott

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Dec 11, 2015
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Dec 11, 2015
@Trott
Copy link
Member

Trott commented Dec 11, 2015

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Dec 12, 2015

LGTM

@Fishrock123
Copy link
Contributor Author

@Fishrock123
Copy link
Contributor Author

CI seems happy (enough), landing.

Refs: nodejs#2224 (comment)
PR-URL: nodejs#4247
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 force-pushed the parallalize-repl-test branch from 217db48 to 7598ed6 Compare December 14, 2015 18:43
@Fishrock123 Fishrock123 merged commit 7598ed6 into nodejs:master Dec 14, 2015
@Fishrock123 Fishrock123 deleted the parallalize-repl-test branch December 14, 2015 18:44
Fishrock123 added a commit that referenced this pull request Dec 15, 2015
Refs: #2224 (comment)
PR-URL: #4247
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Fishrock123 added a commit that referenced this pull request Dec 30, 2015
Refs: #2224 (comment)
PR-URL: #4247
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Refs: #2224 (comment)
PR-URL: #4247
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Refs: nodejs#2224 (comment)
PR-URL: nodejs#4247
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants