test: fix debug-port-cluster flakiness #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: nodejs#4310 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
I'm going to close #4258 in favor of this one. This approach seems less prone to flakiness. |
|
LGTM |
bnoordhuis
force-pushed
the
fix-debug-port-cluster
branch
from
6757182 to
2859f9e
Compare
|
|
||
| var args = [ | ||
| '--debug=' + port, | ||
| '--debug=' + PORT_MIN, |
There was a problem hiding this comment.
very minor nit... since we're starting to use template strings more frequently... perhaps:
`--debug=${PORT_MIN}`
There was a problem hiding this comment.
I had that in my first (unpushed) revision but then I thought "meh, change for the sake of it and incongruous with the line below" so I left it out.
|
LGTM |
|
ha! ok, nevermind, just noticed that it landed lol |
bnoordhuis
added a commit
that referenced
this pull request
Dec 16, 2015
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
bnoordhuis
added a commit
that referenced
this pull request
Dec 30, 2015
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: #4310 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Rewrite the test so that stderr reordering of the child processes won't confuse the test's expectations. PR-URL: nodejs#4310 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the test so that stderr reordering of the child processes won't
confuse the test's expectations.
CI: https://ci.nodejs.org/job/node-test-pull-request/1013/