test: remove unused var from test-assert.js #4405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
assert
|
LGTM |
|
CI: https://ci.nodejs.org/job/node-test-commit/1536/ EDIT: PPC buildbot failures but everything else looks normal. |
|
Fails looks related to github issues. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 26, 2015
`aethrow` is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests. PR-URL: nodejs#4405 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 686a85f |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
`aethrow` is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests. PR-URL: nodejs#4405 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 13, 2016
`aethrow` is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests. PR-URL: #4405 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
`aethrow` is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests. PR-URL: #4405 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
`aethrow` is defined as a function returned from makeBlock() but the function is never used and the call to makeBlock() does not run any tests. PR-URL: nodejs#4405 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aethrowis defined as a function returned frommakeBlock()but the function is never used and the call tomakeBlock()does not run any tests.