Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade libuv to 1.8.0 #4276

Merged
merged 1 commit into from
Dec 14, 2015
Merged

deps: upgrade libuv to 1.8.0 #4276

merged 1 commit into from
Dec 14, 2015

Conversation

saghul
Copy link
Member

@saghul saghul commented Dec 14, 2015

R=@bnoordhuis

/cc @nodejs/collaborators

@rvagg items for release notes:

  • AIX improvements

@saghul
Copy link
Member Author

saghul commented Dec 14, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/995/

@saghul saghul added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Dec 14, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Dec 14, 2015

Rubber stamp LGTM if the CI is happy.

@seishun
Copy link
Contributor

seishun commented Dec 14, 2015

Merging this should fix #3718.

@jasnell
Copy link
Member

jasnell commented Dec 14, 2015

LGTM if CI is green

@saghul
Copy link
Member Author

saghul commented Dec 14, 2015

@seishun good catch, thanks.

@saghul
Copy link
Member Author

saghul commented Dec 14, 2015

Is this the new way of Jenkins telling me the build is green? https://ci.nodejs.org/job/node-test-commit/1431/

@cjihrig
Copy link
Contributor

cjihrig commented Dec 14, 2015

@saghul yes, it looks like the only failures are known flakey tests on Windows.

@saghul
Copy link
Member Author

saghul commented Dec 14, 2015

Oh, forgot to mention, we now have uv_fs_realpath.

@saghul
deps: upgrade libuv to 1.8.0
69b94ec 
Fixes: nodejs#3718
PR-URL: nodejs#4276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@saghul saghul closed this Dec 14, 2015
@saghul saghul deleted the uv-upgrade branch December 14, 2015 20:55
@saghul saghul merged commit 69b94ec into nodejs:master Dec 14, 2015
@saghul
Copy link
Member Author

saghul commented Dec 14, 2015

Merged, thanks for the reviews! ❤️

@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
Closed
saghul added a commit that referenced this pull request Dec 15, 2015
@saghul @cjihrig
deps: upgrade libuv to 1.8.0
2cfc407 
Fixes: #3718
PR-URL: #4276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig added a commit that referenced this pull request Dec 15, 2015
@cjihrig
2015-12-15, Version 5.3.0 (Stable)
ea5f3ab 
Notable changes:

* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281
cjihrig added a commit that referenced this pull request Dec 16, 2015
@cjihrig
2015-12-16, Version 5.3.0 (Stable)
b21110f 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281
cjihrig added a commit that referenced this pull request Dec 16, 2015
@cjihrig
2015-12-16, Version 5.3.0 (Stable)
e5774c9 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: #4281

Conflicts:
	src/node_version.h
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
@evanlucas
Copy link
Contributor

@jasnell can this be backported to LTS? It fixes a segfault on OS X (#4091)

@rvagg
Copy link
Member

rvagg commented Dec 30, 2015

Worth pulling in @nodejs/lts on this one, do we need to think on our policy re libuv & LTS or is case-by-case OK? It seems for this particular upgrade we get some AIX improvements and the fix for #4091 — please consider that issue, I can't work out whether it should be considered a rare edge-case or something that will come up now and again for Argon users.

@saghul
Copy link
Member Author

saghul commented Dec 30, 2015

FWIW, libuv v1.x keeps a strict backwards API compatibility and ABI stability, so pulling in every v1.x release into LTS should never result in breakage.

@jasnell
Copy link
Member

jasnell commented Dec 30, 2015

So long as there is no ABI breakage I've got no problem with that.
On Dec 30, 2015 5:04 AM, "Rod Vagg" notifications@github.com wrote:

Worth pulling in @nodejs/lts https://github.com/orgs/nodejs/teams/lts
on this one, do we need to think on our policy re libuv & LTS or is
case-by-case OK? It seems for this particular upgrade we get some AIX
improvements and the fix for #4091
#4091 — please consider that
issue, I can't work out whether it should be considered a rare edge-case or
something that will come up now and again for Argon users.

—
Reply to this email directly or view it on GitHub
#4276 (comment).

saghul added a commit that referenced this pull request Jan 6, 2016
@saghul
deps: upgrade libuv to 1.8.0
c23dea8 
Fixes: #3718
PR-URL: #4276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

I've landed this onto v4.x-staging.

Here is a CI run to be safe --> https://ci.nodejs.org/job/node-test-commit/1636/

MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@saghul
deps: upgrade libuv to 1.8.0
1ebb0c0 
Fixes: #3718
PR-URL: #4276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@saghul
deps: upgrade libuv to 1.8.0
05ad666 
Fixes: nodejs#3718
PR-URL: nodejs#4276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@cjihrig
2015-12-16, Version 5.3.0 (Stable)
c74c53a 
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) nodejs#3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) nodejs#4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) nodejs#4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) nodejs#4276.

PR-URL: nodejs#4281

Conflicts:
	src/node_version.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@saghul @cjihrig @seishun @jasnell @evanlucas @rvagg @MylesBorins @silverwind