buffer,lib: update atob to align wpt's base64.json #43901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
aduh95
reviewed
Jul 19, 2022
aduh95
reviewed
Jul 28, 2022
aduh95
reviewed
Jul 28, 2022
aduh95
reviewed
Jul 28, 2022
aduh95
reviewed
Jul 30, 2022
| @@ -1277,13 +1280,36 @@ function atob(input) { | |||
| // The first 5 elements of `kForgivingBase64AllowedChars` are | |||
| // ASCII whitespace char codes. | |||
| nonAsciiWhitespaceCharCount++; | |||
|
|
|||
| if (index === kEqualSignIndex) { | |||
There was a problem hiding this comment.
If you put this check here, you don't need to repeat the throw lazyDOMException part, right?
Suggested change
| if (index === kEqualSignIndex) { | |
| if (index === kEqualSignIndex && equalCharCount !== 2) { |
Other than that, LGTM
jasnell
approved these changes
Aug 28, 2022
github-actions
bot
removed
the
request-ci
This was referenced Aug 31, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
XadillaX
added a commit
that referenced
this pull request
Oct 9, 2022
Refs: https://html.spec.whatwg.org/multipage/webappapis.html#dom-atob-dev Refs: https://infra.spec.whatwg.org/#forgiving-base64-decode PR-URL: #43901 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 3a7fcdc |
18 tasks
15 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Refs: https://html.spec.whatwg.org/multipage/webappapis.html#dom-atob-dev Refs: https://infra.spec.whatwg.org/#forgiving-base64-decode PR-URL: #43901 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://html.spec.whatwg.org/multipage/webappapis.html#dom-atob-dev
Refs: https://infra.spec.whatwg.org/#forgiving-base64-decode