v18.11.0 proposal #44968
Merged
v18.11.0 proposal #44968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, process initialization has been a bit all over the place in Node.js. `InitializeNodeWithArgs()` is our main public API for this, but inclusion of items in it vs. `InitializeOncePerProcess()` and `PlatformInit()` has been random at best. Likewise, some pieces of initialization have been guarded by `NODE_SHARED_MODE`, but also fairly randomly and without any meaningful connection to shared library usage. This leaves embedders in a position to cherry-pick some of the initialization code into their own code to make their application behave like typical Node.js applications to the degree to which they desire it. Electron takes an alternative route and makes direct use of `InitializeOncePerProcess()` already while it is a private API, with a `TODO` to add it to the public API in Node.js. This commit addresses that `TODO`, and `TODO`s around the `NODE_SHARED_MODE` usage. Specifically: - `InitializeOncePerProcess()` and `TearDownOncePerProcess()` are added to the public API. - The `flags` option of these functions are merged with the `flags` option for `InitializeNodeWithArgs()`, since they essentially share the same semantics. - The return value of the function is made an abstract class, rather than a struct, for easier API/ABI stability. - Initialization code from `main()` is brought into these functions (since that makes sense in general). - Add a `TODO` for turning `InitializeNodeWithArgs()` into a small wrapper around `InitializeOncePerProcess()` and eventually removing it (at least one major release cycle each, presumably). - Remove `NODE_SHARED_MODE` guards and replace them with runtime options. PR-URL: #44121 Backport-PR-URL: #44358 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13 that fixes the following debug mode build error with clang: ../deps/v8/src/codegen/register.h:29:48: error: member reference base type 'RegListBase' is not a structure or union int num_different_regs = RegListBase{regs...}.Count(); Fixes: #44371 PR-URL: #44392 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #44776 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #44778 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closes: #44773 PR-URL: #44774 Fixes: #44773 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Updated rule from deprecated function-style format to object-style format. Refs: https://eslint.org/docs/latest/developer-guide/working-with-rules PR-URL: #44706 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #44685 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #44684 Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #44696 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #44682 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> PR-URL: #44717 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #44680 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Remove redundant use of "currently" and fix a comma splice. PR-URL: #44789 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #44763 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #44779 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #44694 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
For the initial iteration, only the default resolver can be serialized/deserialized. If `dns.setServers()` has been called, we'll preserve the configured DNS servers in the snapshot. We can consider exposing the serialization method if it becomes necessary for user-land snapshots. PR-URL: #44633 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
The comments in bootstrap/node.js are now out of date due to recent changes to the bootstrap process. Update them to reflect the current status. PR-URL: #44726 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
execSync() passes opts.args to checkExecSyncError(). There are two problems: 1. opts.args appears to always be undefined. 2. Even if it was defined, checkExecSyncError() would not use it since the command input is guaranteed to be defined. This commit updates the code to pass undefined instead. PR-URL: #44766 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The name of the position being validated by validatePosition() was not being used. Instead, the string 'position' was being used everywhere. It worked out because the only call sites were using the name 'position' as well. PR-URL: #44767 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #44772 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
added a commit
that referenced
this pull request
Oct 13, 2022
watch mode (experimental): Running in 'watch' mode using `node --watch` restarts the process when an imported file is changed. Contributed by Moshe Atlow in [#44366](#44366) Other notable changes: * fs: * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel) #42590 * http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * http2: * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820 * lib: * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048 * src: * (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121 * util: * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631 PR-URL: #44968
This comment was marked as outdated.
This comment was marked as outdated.
danielleadams
added a commit
that referenced
this pull request
Oct 13, 2022
watch mode (experimental): Running in 'watch' mode using `node --watch` restarts the process when an imported file is changed. Contributed by Moshe Atlow in [#44366](#44366) Other notable changes: * fs: * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel) #42590 * http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * http2: * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820 * lib: * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048 * src: * (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121 * util: * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631 PR-URL: #44968
danielleadams
force-pushed
the
v18.11.0-proposal
branch
from
c8aacb3 to
6d3a9e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
danielleadams
force-pushed
the
v18.11.0-proposal
branch
from
6d3a9e3 to
18f0262
Compare
danielleadams
added a commit
that referenced
this pull request
Oct 13, 2022
watch mode (experimental): Running in 'watch' mode using `node --watch` restarts the process when an imported file is changed. Contributed by Moshe Atlow in #44366 Other notable changes: * fs: * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel) #42590 * http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * http2: * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820 * lib: * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048 * src: * (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121 * util: * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631 PR-URL: #44968
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
watch mode (experimental): Running in 'watch' mode using `node --watch` restarts the process when an imported file is changed. Contributed by Moshe Atlow in #44366 Other notable changes: * fs: * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel) #42590 * http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * http2: * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820 * lib: * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048 * src: * (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121 * util: * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631 PR-URL: #44968
danielleadams
force-pushed
the
v18.11.0-proposal
branch
from
18f0262 to
8c1dd95
Compare
@richardlau Thanks for catching that! |
danielleadams
added a commit
that referenced
this pull request
Oct 13, 2022
watch mode (experimental): Running in 'watch' mode using `node --watch` restarts the process when an imported file is changed. Contributed by Moshe Atlow in #44366 Other notable changes: * fs: * (SEMVER-MINOR) add `FileHandle.prototype.readLines` (Antoine du Hamel) #42590 * http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * http2: * (SEMVER-MINOR) make early hints generic (Yagiz Nizipli) #44820 * lib: * (SEMVER-MINOR) refactor transferable AbortSignal (flakey5) #44048 * src: * (SEMVER-MINOR) add detailed embedder process initialization API (Anna Henningsen) #44121 * util: * (SEMVER-MINOR) add default value option to parsearg (Manuel Spigolon) #44631 PR-URL: #44968
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 14, 2022
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 14, 2022
danielleadams
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 14, 2022
This was referenced Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2022-10-13, Version 18.11.0 (Current), @danielleadams
watch mode (experimental)
Running in 'watch' mode using
node --watchrestarts the process when an imported file is changed.Contributed by Moshe Atlow in #44366
Other notable changes
FileHandle.prototype.readLines(Antoine du Hamel) #42590Commits
27b4b782ce] - benchmark: add vm context global proxy benchmark (Joyee Cheung) #447964e82521af1] - bootstrap: update comments in bootstrap/node.js (Joyee Cheung) #44726725be0ea50] - buffer: initialize TextDecoder once on blob.text() (Yagiz Nizipli) #44787653c3b1f62] - buffer,lib: update atob to align wpt's base64.json (Khaidi Chu) #4390137808b3355] - build: convert V8 test JSON to JUnit XML (Keyhan Vakil) #44049f92871a52b] - build: update timezone-update.yml (Alex) #44717f85d3471ee] - child_process: remove lookup of undefined property (Colin Ihrig) #447662f5f41c315] - (SEMVER-MINOR) cli: add--watch(Moshe Atlow) #443667fb9cc70f3] - cluster: use inspector utils (Moshe Atlow) #4459299a2c16040] - crypto: add causes to applicable webcrypto's OperationError (Filip Skokan) #44890e0fbba0939] - crypto: use EVP_PKEY_CTX_set_dsa_paramgen_q_bits when available (David Benjamin) #44561a90386b0a1] - deps: update undici to 5.11.0 (Node.js GitHub Bot) #44929aa68d40fbf] - deps: update corepack to 0.14.2 (Node.js GitHub Bot) #44775c892f35815] - deps: V8: fix debug build (Ben Noordhuis) #4439291514393dc] - dns: support dns module in the snapshot (Joyee Cheung) #44633ce3cb29319] - doc: add fsPromises.readFile() example (Tierney Cyren) #4023797df9b84a2] - doc: improve building doc for Android (BuShe Pie) #448888c69da893b] - doc: mentioncorepack preparesupports tag or range (Michael Rienstra) #44646842bc64833] - doc: remove Legacy status from querystring (Rich Trott) #44912ddb5402f5f] - doc: fix label name in collaborator guide (Rich Trott) #44920d08b024a3d] - doc: fix typo in Node.js 12 changelog (Lorand Horvath) #42880b6b9c427c5] - doc: move release keys we don't use anymore in README (Rich Trott) #44899e92b074b32] - doc: fix grammar in dns docs (doc: grammar fix in dns docs #44850) (Colin Ihrig) #44850780144c339] - doc: remove unnecessary leading commas (Colin Ihrig) #448546ae9bc8fbc] - doc: add extra step for reporter pre-approval (Rafael Gonzaga) #44806ccf31d8bca] - doc: add anchor link for --preserve-symlinks (Kohei Ueno) #448587c5c19ee54] - doc: update node prefix require.cache example (Simone Busoli) #447242a5bce6318] - doc: include last security release date (Vladimir de Turckheim) #447944efaf4265c] - doc: remove "currently" and comma splice from child_process.md (Rich Trott) #447893627616b40] - doc,crypto: mark experimental algorithms more visually (Filip Skokan) #448923c653cf23a] - doc,crypto: add missing CFRG curve algorithms to supported lists (Filip Skokan) #4487670f55020d3] - doc,crypto: add null length to crypto.subtle.deriveBits (Filip Skokan) #44876910fbd0ece] - esm: fix duplicated test (Geoffrey Booth) #44779bc00f3bde1] - fs: fix opts.filter issue in cp async (Tho) #4492211d1c23fa0] - (SEMVER-MINOR) fs: addFileHandle.prototype.readLines(Antoine du Hamel) #4259067fb76519a] - fs: improve promise based readFile performance for big files (Ruben Bridgewater) #44295dc6379bdc2] - fs: don't hard code name in validatePosition() (Colin Ihrig) #44767eb19b1e97c] - http: be more aggressive to reply 400, 408 and 431 (ywave620) #448184c869c8d9e] - (SEMVER-MINOR) http: add writeEarlyHints function to ServerResponse (Wing) #441809c7e66478c] - (SEMVER-MINOR) http2: make early hints generic (Yagiz Nizipli) #448203f20e5b15c] - (SEMVER-MINOR) lib: refactor transferable AbortSignal (flakey5) #44048ada7d82b16] - lib: require JSDoc in internal validators code (Rich Trott) #4489667eaa303af] - lib: add cause to DOMException (flakey5) #447030db86ee98e] - meta: update AUTHORS (Node.js GitHub Bot) #449302efe4d985b] - meta: label test.js and test.md with test_runner label (Moshe Atlow) #44863fd9feb3a6c] - meta: update AUTHORS (Node.js GitHub Bot) #44857a854bb39c9] - node-api: create reference only when needed (Gerhard Stöbich) #44827fd5c26b8db] - path: change basename() argument from ext to suffix (Rich Trott) #44774803fbfb168] - process: fix uid/gid validation to avoid crash (Tobias Nießen) #449109f2dd48fc3] - src: remove uid_t/gid_t casts (Tobias Nießen) #449143abb607f3a] - src: remove UncheckedMalloc(0) workaround (Tobias Nießen) #445430606f9298f] - src: deduplicate setting RSA OAEP label (Tobias Nießen) #44849daf3152f7e] - src: implement GetDetachedness() in MemoryRetainerNode (Joyee Cheung) #448037ca77dd4ef] - src: avoid X509_free in loops in crypto_x509.cc (Tobias Nießen) #44855781ad96227] - src: use OnScopeLeave instead of multiple free() (Tobias Nießen) #44852b27b336a7a] - src: remove ParseIP() in cares_wrap.cc (Tobias Nießen) #44771f99f5d3c01] - (SEMVER-MINOR) src: add detailed embedder process initialization API (Anna Henningsen) #44121281fd7a09a] - src,stream: improve DoWrite() and Write() (ywave620) #44434a33cc22bf7] - src,worker: fix race of WorkerHeapSnapshotTaker (ywave620) #44745f300f197da] - stream: handle enqueuing chunks when a pending BYOB pull request exists (Daeyeon Jeong) #447709ac029ea11] - test: bump memory limit for abort fatal error (Danielle Adams) #44984b9b671f25f] - test: debug watch mode inspect (Moshe Atlow) #448612308b71d09] - test: don't clobber RegExp.$_ on startup (Ben Noordhuis) #44864fe91bebb67] - test: loosen test for negative timestamps intest-fs-stat-date(Livia Medeiros) #44707a080608552] - test: check--testis disallowed in NODE_OPTIONS (Kohei Ueno) #44846dc2af265d7] - test: improve lib/internal/source_map/source_map.js coverage (MURAKAMI Masahiko) #4277160a05d6dea] - test: skip some binding tests on IBMi PASE (Richard Lau) #448108dacedaa3d] - test: remove unused variable in addon test (Joyee Cheung) #44809c54cee1c3f] - test: check server status in test-tls-psk-client (Richard Lau) #44824ee3c6a4dc5] - test: use async/await in test-debugger-exceptions (pete3249) #446909f14625fe5] - test: use async/await in test-debugger-help (Chandana) #446868033ad846b] - test: update test-debugger-scripts to use await/async (mmeenapriya) #44692f4f08be384] - test: use await in test-debugger-invalid-json (Anjana Krishnakumar Vellore) #44689d2f36169f3] - test: use async/await in test-debugger-random-port-with-inspect-port (Monu-Chaudhary) #44695ddf029725b] - test: use async/await in test-debugger-heap-profiler (Brinda Ashar) #44693117f068250] - test: use async/await in test-debugger-auto-resume (samyuktaprabhu) #44675143c428cae] - test: migrated from Promise chains to Async/Await (Rathi N Das) #44674e609a3309c] - test: change promises to async/await in test-debugger-backtrace.js (Juliet Zhang) #44677eeabd23ca6] - test: use async/await in test-debugger-sb-before-load (Hope Olaidé) #446975c63d1464e] - test: add extra tests for basename with ext option (Connor Burton) #44772f8b2d7a059] - test: refactor to async/await (Divya Mohan) #446949864bde9ab] - test: modify test-debugger-custom-port.js to use async-await (Priya Shastri) #44680af30823881] - test: upgrade all 1024 bit RSA keys to 2048 bits (Momtchil Momtchev) #444980fb669e31f] - test: update test-debugger-breakpoint-exists.js to use async/await (Archana Kamath) #44682cca253503e] - test: use async/await in test-debugger-preserve-breaks (poorvitusam) #446960b2e8b1681] - test: use async/await in test-debugger-profile (surbhirjain) #446844db72a65cf] - test: change the promises to async/await in test-debugger-exec-scope.js (Ankita Khiratkar) #4468556c9c98963] - test: fix test-runner-inspect (Moshe Atlow) #4462036227ed862] - test: fix watch mode test flake (Moshe Atlow) #447393abd71a0ea] - test: deflake watch mode tests (Moshe Atlow) #446210c9f38f2be] - test: split watch mode inspector tests to sequential (Moshe Atlow) #44551d762a34128] - test_runner: add --test-name-pattern CLI flag (Colin Ihrig)c7ece464a1] - test_runner: remove runtime experimental warning (Colin Ihrig) #448443c1e9d41c8] - test_runner: support using--inspectwith--test(Moshe Atlow) #445204bdef48732] - tools: remove faulty early termination logic from update-timezone.mjs (Darshan Sen) #4487019d8574996] - tools: fix timezone update tool (Darshan Sen) #44870ad8b8ae7d3] - tools: update eslint to 8.25.0 (Node.js GitHub Bot) #44931fd99b17a4d] - tools: makeutils.SearchFilesdeterministic (Bruno Pitrus) #44496131adece37] - tools: fix typo in tools/update-authors.mjs (Darshan Sen) #44780ab22777e65] - tools: refactor deprecated format in no-unescaped-regexp-dot (Madhuri) #447633ad0fae89d] - tools: update eslint-check.js to object style (andiemontoyeah) #44706e9d572a9bd] - tools: update eslint to 8.24.0 (Node.js GitHub Bot) #44778984b0b4a6c] - tools: update lint-md-dependencies to rollup@2.79.1 (Node.js GitHub Bot) #44776db5aeed702] - (SEMVER-MINOR) util: add default value option to parsearg (Manuel Spigolon) #44631576ccdf125] - util: increase robustness with primordials (Jordan Harband) #41212