Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve building doc for Android #44888

Merged
merged 1 commit into from
Oct 10, 2022
Merged

doc: improve building doc for Android #44888

merged 1 commit into from
Oct 10, 2022

Conversation

MeowShe
Copy link
Contributor

@MeowShe MeowShe commented Oct 4, 2022 •
edited
Loading

Improved building doc for Android.

Refs: #44207

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 4, 2022
@MeowShe
Copy link
Contributor Author

MeowShe commented Oct 4, 2022 •
edited
Loading

@F3n67u Hi, due to time constraints, I have submitted an update to the documentation first, and thank you for keep following the pull requests for this series coming in, and if the pr looks good to you, approve it please.

@F3n67u
Copy link
Member

F3n67u commented Oct 4, 2022

@F3n67u Hi, due to time constraints, I have submitted an update to the documentation first, and thank you for keeping the pull requests for this series coming in, and if the pr looks good to you, approve it please.

Thanks for your contribution.

@F3n67u F3n67u added the review wanted PRs that need reviews. label Oct 5, 2022
@MeowShe MeowShe mentioned this pull request Oct 7, 2022
Merged
@F3n67u F3n67u added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1124558 into nodejs:main Oct 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1124558

@MeowShe MeowShe deleted the android-build branch October 11, 2022 00:16
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@MeowShe @danielleadams
doc: improve building doc for Android
97df9b8 
PR-URL: #44888
Refs: #44207
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F3n67u F3n67u F3n67u approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MeowShe @F3n67u @nodejs-github-bot @jasnell