src: speed up `process.getActiveResourcesInfo()` #46014

RaisinTen · 2022-12-29T14:11:08Z

This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance by 75%!

Refs: #44445 (review)
Signed-off-by: Darshan Sen raisinten@gmail.com

process.getActiveResourcesInfo() benchmark result: 75% improvement
timers benchmark result: no noticeable deterioration

This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance. Refs: nodejs#44445 (review) Signed-off-by: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot · 2022-12-29T14:11:12Z

Review requested:

@nodejs/startup

aduh95 · 2022-12-29T19:08:52Z

Benchmark CI: https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1280

                                                                                                                            confidence improvement accuracy (*)   (**)  (***)
process/getActiveResourcesInfo.js n=100000 immediatesCount=10000 timeoutsCount=10000 requestsCount=10000 handlesCount=10000        ***     75.23 %       ±4.60% ±6.19% ±8.19%

aduh95 · 2022-12-29T20:19:51Z

Benchmark CI(timers): https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1281

Results

                                                             confidence improvement accuracy (*)    (**)   (***)
timers/immediate.js type='breadth' n=5000000                                 0.55 %       ±1.51%  ±2.02%  ±2.63%
timers/immediate.js type='breadth1' n=5000000                               -0.66 %       ±1.90%  ±2.53%  ±3.30%
timers/immediate.js type='breadth4' n=5000000                               -2.26 %       ±4.90%  ±6.52%  ±8.49%
timers/immediate.js type='clear' n=5000000                           **      3.84 %       ±2.51%  ±3.34%  ±4.36%
timers/immediate.js type='depth' n=5000000                          ***      4.91 %       ±2.09%  ±2.81%  ±3.70%
timers/immediate.js type='depth1' n=5000000                                  2.35 %       ±2.66%  ±3.55%  ±4.65%
timers/set-immediate-breadth-args.js n=5000000                               0.08 %       ±4.30%  ±5.72%  ±7.44%
timers/set-immediate-breadth.js n=10000000                                   1.91 %       ±2.16%  ±2.87%  ±3.75%
timers/set-immediate-depth-args.js n=5000000                                 1.23 %       ±2.30%  ±3.06%  ±3.98%
timers/timers-breadth-args.js n=1000000                                     -0.74 %       ±6.10%  ±8.11% ±10.56%
timers/timers-breadth.js n=5000000                                           2.99 %       ±6.06%  ±8.06% ±10.49%
timers/timers-cancel-pooled.js n=5000000                                     3.68 %       ±7.33%  ±9.75% ±12.69%
timers/timers-cancel-unpooled.js direction='end' n=1000000                  -4.24 %      ±10.53% ±14.01% ±18.23%
timers/timers-cancel-unpooled.js direction='start' n=1000000                 0.44 %       ±3.24%  ±4.31%  ±5.61%
timers/timers-depth.js n=1000                                               -0.07 %       ±0.48%  ±0.64%  ±0.85%
timers/timers-insert-pooled.js n=5000000                              *      4.61 %       ±4.39%  ±5.84%  ±7.61%
timers/timers-insert-unpooled.js direction='end' n=1000000                  -0.92 %       ±1.74%  ±2.32%  ±3.02%
timers/timers-insert-unpooled.js direction='start' n=1000000                -0.22 %       ±2.04%  ±2.71%  ±3.53%
timers/timers-timeout-nexttick.js n=50000                                   -0.75 %       ±2.58%  ±3.43%  ±4.48%
timers/timers-timeout-nexttick.js n=5000000                                 -2.15 %       ±5.46%  ±7.27%  ±9.46%
timers/timers-timeout-pooled.js n=10000000                                   2.97 %       ±6.69%  ±8.90% ±11.59%
timers/timers-timeout-unpooled.js n=1000000                                  0.22 %       ±1.68%  ±2.25%  ±2.94%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 22 comparisons, you can thus
expect the following amount of false-positive results:
  1.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.22 false positives, when considering a   1% risk acceptance (**, ***),
  0.02 false positives, when considering a 0.1% risk acceptance (***)

lib/internal/timers.js

anonrig · 2023-01-01T20:54:38Z

src/node_process_methods.cc

  Environment* env = Environment::GetCurrent(args);
+  std::vector<Local<Value>> resources_info;


I wonder if you can omit using std::vector for better performance in here.

Any suggestions on how you think that can be done?

Refs: nodejs#46014 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

lib/internal/timers.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2023-01-03T08:15:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48821/

nodejs-github-bot · 2023-01-03T09:22:14Z

Commit Queue failed

- Loading data for nodejs/node/pull/46014
✔  Done loading data for nodejs/node/pull/46014
----------------------------------- PR info ------------------------------------
Title      src: speed up `process.getActiveResourcesInfo()` (#46014)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:src/speed-up-process.getActiveResourcesInfo -> nodejs:main
Labels     c++, lib / src, author ready, needs-ci, commit-queue-squash
Commits    3
 - src: speed up process.getActiveResourcesInfo()
 - lib: explain timeoutInfo
 - lib: update comment
Committers 2
 - Darshan Sen 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/46014
Reviewed-By: Antoine du Hamel 
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46014
Reviewed-By: Antoine du Hamel 
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - lib: update comment
   ℹ  This PR was created on Thu, 29 Dec 2022 14:11:08 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46014#pullrequestreview-1232745904
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/46014#pullrequestreview-1233540022
   ✔  Last GitHub CI successful
   ℹ  Last Benchmark CI on 2022-12-29T20:19:51Z: https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1281
   ℹ  Last Full PR CI on 2023-01-03T08:15:41Z: https://ci.nodejs.org/job/node-test-pull-request/48821/
- Querying data for job/node-test-pull-request/48821/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3828266911

nodejs-github-bot · 2023-01-03T10:36:27Z

Landed in e35e893

This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance. Refs: nodejs#44445 (review) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#46014 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance. Refs: #44445 (review) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46014 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 29, 2022

aduh95 approved these changes Dec 29, 2022

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 29, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2022

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Dec 30, 2022

CI Reliability 2022-12-30 nodejs/reliability#473

Open

10 tasks

This comment was marked as outdated.

Sign in to view

This was referenced Dec 31, 2022

CI Reliability 2022-12-31 nodejs/reliability#474

Open

CI Reliability 2023-01-01 nodejs/reliability#475

Open

anonrig reviewed Jan 1, 2023

View reviewed changes

github-actions bot mentioned this pull request Jan 2, 2023

CI Reliability 2023-01-02 nodejs/reliability#476

Open

22 tasks

lib: explain timeoutInfo

6e81c2c

Refs: nodejs#46014 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

RaisinTen added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 2, 2023

legendecas approved these changes Jan 2, 2023

View reviewed changes

aduh95 reviewed Jan 2, 2023

View reviewed changes

lib/internal/timers.js Outdated Show resolved Hide resolved

lib: update comment

1da9e75

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

github-actions bot mentioned this pull request Jan 3, 2023

CI Reliability 2023-01-03 nodejs/reliability#477

Open

23 tasks

This comment was marked as outdated.

Sign in to view

RaisinTen requested a review from aduh95 January 3, 2023 09:12

RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 3, 2023

legendecas approved these changes Jan 3, 2023

View reviewed changes

RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 3, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 3, 2023

nodejs-github-bot merged commit e35e893 into nodejs:main Jan 3, 2023

RaisinTen deleted the src/speed-up-process.getActiveResourcesInfo branch January 3, 2023 10:37

This was referenced Jan 4, 2023

CI Reliability 2023-01-04 nodejs/reliability#478

Open

CI Reliability 2023-01-05 nodejs/reliability#479

Open

RafaelGSS mentioned this pull request Jan 20, 2023

v19.5.0 proposal #46286

Merged

juanarbol mentioned this pull request Jan 28, 2023

V18.14.0 proposal #46396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: speed up `process.getActiveResourcesInfo()` #46014

src: speed up `process.getActiveResourcesInfo()` #46014

RaisinTen commented Dec 29, 2022 •

edited

Loading

nodejs-github-bot commented Dec 29, 2022

aduh95 commented Dec 29, 2022

aduh95 commented Dec 29, 2022

This comment was marked as outdated.

This comment was marked as outdated.

anonrig Jan 1, 2023

RaisinTen Jan 2, 2023

This comment was marked as outdated.

nodejs-github-bot commented Jan 3, 2023

nodejs-github-bot commented Jan 3, 2023

nodejs-github-bot commented Jan 3, 2023

		Environment* env = Environment::GetCurrent(args);
		std::vector<Local<Value>> resources_info;

src: speed up process.getActiveResourcesInfo() #46014

src: speed up process.getActiveResourcesInfo() #46014

Conversation

RaisinTen commented Dec 29, 2022 • edited Loading

nodejs-github-bot commented Dec 29, 2022

aduh95 commented Dec 29, 2022

aduh95 commented Dec 29, 2022

This comment was marked as outdated.

This comment was marked as outdated.

anonrig Jan 1, 2023

Choose a reason for hiding this comment

RaisinTen Jan 2, 2023

Choose a reason for hiding this comment

This comment was marked as outdated.

nodejs-github-bot commented Jan 3, 2023

nodejs-github-bot commented Jan 3, 2023

nodejs-github-bot commented Jan 3, 2023

src: speed up `process.getActiveResourcesInfo()` #46014

src: speed up `process.getActiveResourcesInfo()` #46014

RaisinTen commented Dec 29, 2022 •

edited

Loading