Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.5.0 proposal #46286

Merged
merged 107 commits into from
Jan 24, 2023
Merged

v19.5.0 proposal #46286

merged 107 commits into from
Jan 24, 2023

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jan 20, 2023

2023-01-24, Version 19.5.0 (Current), @RafaelGSS

Notable Changes

  • http:
    • (SEMVER-MINOR) join authorization headers (Marco Ippolito) #45982
  • lib::
    • add webstreams to Duplex.from() (Debadree Chatterjee) #46190
  • stream:
    • implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) #46205

Commits

  • [def36946da] - assert: remove assert.snapshot (Moshe Atlow) #46112
  • [e1c56ec3fd] - benchmark,tools: use os.availableParallelism() (Deokjin Kim) #46003
  • [370f621d4d] - build: add extra semi check (Jiawen Geng) #46194
  • [476c6f892d] - crypto: avoid hang when no algorithm available (Richard Lau) #46237
  • [8b22310940] - (SEMVER-MINOR) crypto: add CryptoKey Symbol.toStringTag (Filip Skokan) #46042
  • [78be87b9f9] - crypto: add cipher update/final methods encoding validation (vitpavlenko) #45990
  • [dc0cdaa101] - crypto: ensure auth tag set for chacha20-poly1305 (Ben Noordhuis) #46185
  • [1146f02dc5] - crypto: return correct bit length in KeyObject's asymmetricKeyDetails (Filip Skokan) #46106
  • [961710bb72] - (SEMVER-MINOR) crypto: add KeyObject Symbol.toStringTag (Filip Skokan) #46043
  • [9cfdac6c82] - deps: V8: cherry-pick e39af94dd18e (Lu Yahan) #46142
  • [26cde8efb7] - deps: update simdutf to 3.1.0 (Node.js GitHub Bot) #46257
  • [3f9fb37130] - deps: cherrypick simdutf patch (Jiawen Geng) #46194
  • [4ff2822836] - deps: bump googletest to 2023.01.13 (Jiawen Geng) #46198
  • [49556247d2] - deps: add /deps/**/.github/ to .gitignore (Luigi Pinca) #46091
  • [0c4df83e0d] - deps: add simdutf version to metadata (Mike Roth) #46145
  • [69aafc3ddd] - deps: update simdutf to 2.1.0 (Node.js GitHub Bot) #46128
  • [a266daccb5] - deps: update corepack to 0.15.3 (Node.js GitHub Bot) #46037
  • [6cd70573eb] - deps: upgrade npm to 9.3.1 (npm team) #46242
  • [679aae2da8] - deps: upgrade npm to 9.3.0 (npm team) #46193
  • [38dd5061f2] - dgram: sync the old handle state to new handle (theanarkh) #46041
  • [e36af49b35] - doc: fix mismatched arguments of NodeEventTarget (Deokjin Kim) #45678
  • [58b836f7c4] - doc: update events API example to have runnable code (Deokjin Kim) #45760
  • [5c350298b4] - doc: add note to tls docs about secureContext availability (Tim Gerk) #46224
  • [90924ce198] - doc: add text around collaborative expectations (Michael Dawson) #46121
  • [2d328355d4] - doc: update to match changed --dns-result-order default (Mordy Tikotzky) #46148
  • [1015a606b7] - doc: add Node-API media link (Kevin Eady) #46189
  • [6e355efcff] - doc: update http.setMaxIdleHTTPParsers arguments (Debadree Chatterjee) #46168
  • [f18ab9405a] - doc: use "file system" instead of "filesystem" (Rich Trott) #46178
  • [1b45713b00] - doc: https update default request timeout (Marco Ippolito) #46184
  • [4c88721e2f] - doc: make options of readableStream.pipeTo as optional (Deokjin Kim) #46180
  • [538c53f010] - doc: add PerformanceObserver.supportedEntryTypes to doc (theanarkh) #45962
  • [eef7489d24] - doc: duplex and readable from uncaught execption warning (Marco Ippolito) #46135
  • [686fe585b5] - doc: remove outdated sections from maintaining-v8 (Antoine du Hamel) #46137
  • [2e826ad528] - doc: fix (EC)DHE remark in TLS docs (Tobias Nießen) #46114
  • [2e22b29add] - doc: fix ERR_TLS_RENEGOTIATION_DISABLED text (Tobias Nießen) #46122
  • [e222a2f1d1] - doc: fix spelling in SECURITY.md (Vaishno Chaitanya) #46124
  • [7718e82f0d] - doc: abort controller emits error in child process (Debadree Chatterjee) #46072
  • [76408bc1ed] - doc: fix event.cancelBubble documentation (Deokjin Kim) #45986
  • [82023f2570] - doc: update output of example in inspector (Deokjin Kim) #46073
  • [a42fc512b6] - doc: add personal pronouns option (Filip Skokan) #46118
  • [fafae5955d] - doc: mention how to run ncu-ci citgm (Rafael Gonzaga) #46090
  • [e1fd2f24d9] - doc: include updating release optional step (Rafael Gonzaga) #46089
  • [1996e610fd] - doc: describe argument of Symbol.for (Deokjin Kim) #46019
  • [b002330216] - doc,crypto: fix WebCryptoAPI import keyData and export return (Filip Skokan) #46076
  • [fa3e0c86c7] - esm: mark importAssertions as required (Antoine du Hamel) #46164
  • [f85a8e4c59] - events: add initEvent to Event (Deokjin Kim) #46069
  • [5bdfaae680] - events: change status of event.returnvalue to legacy (Deokjin Kim) #46175
  • [ad7846fe97] - events: change status of event.cancelBubble to legacy (Deokjin Kim) #46146
  • [5304c89682] - events: change status of event.srcElement to legacy (Deokjin Kim) #46085
  • [3dcdab3f16] - events: check signal before listener (Deokjin Kim) #46054
  • [907d67de76] - http: refactor to use validateHeaderName (Deokjin Kim) #46143
  • [ae5141cb8a] - http: writeHead if statusmessage is undefined dont override headers (Marco Ippolito) #46173
  • [6e7f9fbc1d] - http: refactor to use min of validateNumber for maxTotalSockets (Deokjin Kim) #46115
  • [069a30bc4e] - (SEMVER-MINOR) http: join authorization headers (Marco Ippolito) #45982
  • [68cde4cbcc] - lib: add webstreams to Duplex.from() (Debadree Chatterjee) #46190
  • [4d73ea708b] - lib: use kEmptyObject and update JSDoc in webstreams (Deokjin Kim) #46183
  • [1cfa2e6762] - lib: refactor to use validate function (Deokjin Kim) #46101
  • [2eb87f23c9] - lib: reuse invalid state errors on webstreams (Rafael Gonzaga) #46086
  • [8684dae8d9] - lib: fix incorrect use of console intrinsic (Colin Ihrig) #46044
  • [d044ed1d3e] - meta: update AUTHORS (Node.js GitHub Bot) #46215
  • [5261560757] - meta: update AUTHORS (Node.js GitHub Bot) #46130
  • [1b557bbee8] - meta: update comment in CODEOWNERS to better reflect current policy (Antoine du Hamel) #45944
  • [54896ab011] - module: fix unintended mutation (Antoine du Hamel) #46108
  • [bd98e5baba] - node-api: disambiguate napi_add_finalizer (Chengzhong Wu) #45401
  • [f0508894d6] - perf_hooks: fix checking range of options.figures in createHistogram (Deokjin Kim) #45999
  • [e482d5e42d] - src: fix endianness of simdutf (Yagiz Nizipli) #46257
  • [e2c47cdfad] - src: make BuiltinLoader threadsafe and non-global (Anna Henningsen) #45942
  • [36ae3ccff3] - src: replace unreachable code with static_assert (Tobias Nießen) #46209
  • [9d55a1f9a1] - src: hide kMaxDigestMultiplier outside HKDF impl (Tobias Nießen) #46206
  • [d3d62ed82c] - src: distinguish env stopping flags (Chengzhong Wu) #45907
  • [e85f76686c] - src: remove return after abort (Shelley Vohr) #46172
  • [7dc9a53b18] - src: remove unnecessary semicolons (Shelley Vohr) #46171
  • [28af831d5a] - src: use simdutf for converting externalized builtins to UTF-16 (Anna Henningsen) #46119
  • [e8eaa490af] - src: use constant strings for memory info names (Chengzhong Wu) #46087
  • [f4559a1354] - src: fix typo in node_snapshotable.cc (Vadim) #46103
  • [ca8ff08a5c] - src: keep PipeWrap::Open function consistent with TCPWrap (theanarkh) #46064
  • [a936eaeb34] - src: speed up process.getActiveResourcesInfo() (Darshan Sen) #46014
  • [5cf595659f] - src,lib: the handle keeps loop alive in cluster rr mode (theanarkh) #46161
  • [18695595e1] - stream: fix pipeline calling end on destination more than once (Debadree Chatterjee) #46226
  • [e5f53b51f0] - stream: implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) #46205
  • [2f23f17f93] - test: reduce fs-write-optional-params flakiness (LiviaMedeiros) #46238
  • [255f177108] - test: enable more case of bad buffer in fs.write (Deokjin Kim) #46236
  • [c09b2036c7] - test: update postject to 1.0.0-alpha.4 (Node.js GitHub Bot) #46212
  • [4ac5c7180f] - test: refactor to avoid mutation of global by a loader (Michaël Zasso) #46220
  • [bbf9da8e2c] - test: improve test coverage for WHATWG TextDecoder (Juan José) #45241
  • [4f491d368c] - test: add fix so that test exits if port 42 is unprivileged (Suyash Nayan) #45904
  • [6e2f7228f3] - test: use os.availableParallelism() (Deokjin Kim) #46003
  • [c77b0da512] - test: fix flaky test-runner-exit-code.js (Colin Ihrig) #46138
  • [f309e2acb6] - test: update Web Events WPT (Deokjin Kim) #46051
  • [0f60bc9bbc] - test: add test to once() in event lib (Jonathan Diaz) #46126
  • [8a8b18678a] - test,esm: validate more edge cases for dynamic imports (Antoine du Hamel) #46059
  • [4d3743938f] - test_runner: update comment to comply with eslint no-fallthrough rule (Antoine du Hamel) #46258
  • [653b108fdc] - tools: update eslint to 8.32.0 (Node.js GitHub Bot) #46258
  • [a4b0c916e0] - tools: update lint-md-dependencies (Node.js GitHub Bot) #46214
  • [f4465e656d] - tools: fix macro name in update-undici (Almeida) #46217
  • [1aa4534c6f] - tools: add automation for updating postject dependency (Darshan Sen) #46157
  • [c150b312cd] - tools: update create-or-update-pull-request-action (Michaël Zasso) #46169
  • [c68a043400] - tools: update eslint to 8.31.0 (Node.js GitHub Bot) #46131
  • [ac90e419d1] - tools: update lint-md-dependencies to rollup@3.9.1 (Node.js GitHub Bot) #46129
  • [750fcf84eb] - tools: move update-eslint.sh to dep_updaters/ (Luigi Pinca) #46088
  • [2e8750a18c] - tools: make update-eslint.sh work with npm@9 (Luigi Pinca) #46088
  • [e90a3a6eff] - tools: fix lint rule recommendation (Colin Ihrig) #46044
  • [0985ef8bfb] - tools: add ArrayPrototypeConcat to the list of primordials to avoid (Antoine du Hamel) #44445
  • [ed69a3af92] - tools: add prefer-proto rule (Jordan Harband) #46083
  • [4c1c20fae2] - trace_events: refactor to use validateStringArray (Deokjin Kim) #46012
  • [6c8a81d2dc] - vm: refactor to use validate function (Deokjin Kim) #46176

npm-cli-bot and others added 30 commits January 18, 2023 10:14
PR-URL: #46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #46242
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
fixup: add support for `Object.create(null)`

fixup: extend to any 1-argument Object.create call

fixup: add tests
PR-URL: #46083
Backport-PR-URL: #46239
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #45982
Backport-PR-URL: #46240
Fixes: #45699
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #44445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #46037
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #46041
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This change reduces the number of calls that were crossing the JS-C++
boundary to 1 and also removes the need for calling Array::New()
multiple times internally and ArrayPrototypeConcat-ing the results
later on, thus improving performance.

Refs: #44445 (review)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #46014
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #46043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
The lint rule recommends destructuring console out of the
internal/console/global.js export. However, that does not
exist. The top level export is actually the console object.

PR-URL: #46044
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The console object was not being frozen because the intrinsic
freezing code was accessing undefined instead of the console
object.

PR-URL: #46044
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In WPT Events, TypeError is expected if both listener and
signal are null. But checking listener doesn't throw TypeError.
So check signal before listener because checking signal throws
TypeError if signal is null.

PR-URL: #46054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
napi_add_finalizer doesn't support any operations related to
napi_wrap. Remove the ambiguous statements in the doc about
napi_wrap and avoid reusing the v8impl::Wrap call.

PR-URL: #45401
Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #46059
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Symbol is described with argument, but argument of Symbol.for
is ommited. So describe argument of Symbol.for for consistency.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring
PR-URL: #46019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
We do not enforce signing off by any code owners when landing PRs.

PR-URL: #45944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #46089
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #46090
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
PR-URL: #46118
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #46064
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Actual output of promise example in inspector is mismatched.

PR-URL: #46073
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Setter of `event.cancelBubble` is a no-op if the value passed to it is
not `true`.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: #45986
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fixes: #46036
PR-URL: #46072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #46076
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ImmeidateInfo -> ImmediateInfo

PR-URL: #46103
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
`event.srcElement` is described as legacy in spec.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: #46085
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Refs: #46061 (comment)
PR-URL: #46108
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS added a commit that referenced this pull request Jan 20, 2023
Notable changes:

* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: #46286
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2023
@nodejs-github-bot

This comment was marked as outdated.

Notable changes:

* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: #46286
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49113/ ✔️
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5131/ ✔️
CITGM: https://ci.nodejs.org/job/citgm-smoker/3077/
CITGM(v19.x): https://ci.nodejs.org/job/citgm-smoker/3081/
📦 https://ci-release.nodejs.org/job/iojs+release/9098/ -> https://ci-release.nodejs.org/job/iojs+release/9099/

CITGM Results ✔️
FAILURE: 15 failures in 3077 not present in 3081


┌────────────────────────┬───────────────────────┬───────────────────────┬───────────────────┬────────────────┬───────────────┬───────────────┐
│        (index)         │           0           │           1           │         2         │       3        │       4       │       5       │
├────────────────────────┼───────────────────────┼───────────────────────┼───────────────────┼────────────────┼───────────────┼───────────────┤
│       rhel8-x64        │                       │                       │                   │                │               │               │
│       win-vs2019       │                       │                       │                   │                │               │               │
│     rhel8-ppc64le      │    'async-v3.2.4'     │      'gulp-util'      │ 'inherits-v2.0.4' │ 'level-v8.0.0' │ 'pump-v3.0.0' │ 'tape-v5.6.3' │
│        osx1015         │ 'tough-cookie-v4.1.2' │                       │                   │                │               │               │
│     ubuntu1804-64      │    'async-v3.2.4'     │                       │                   │                │               │               │
│      rhel8-s390x       │                       │                       │                   │                │               │               │
│      aix72-ppc64       │    'async-v3.2.4'     │ 'tough-cookie-v4.1.2' │                   │                │               │               │
│      debian10-x64      │    'bcrypt-v5.1.0'    │   'fastify-v4.11.0'   │   'pino-v8.8.0'   │ 'pump-v3.0.0'  │               │               │
│ fedora-last-latest-x64 │ 'tough-cookie-v4.1.2' │                       │                   │                │               │               │
└────────────────────────┴───────────────────────┴───────────────────────┴───────────────────┴────────────────┴───────────────┴───────────────┘

@jaydenseric
Copy link
Contributor

I can't see mention of the test runner reporters in this proposal, will they be included in the v19.5.0 release? Per previous v19.4.0 discussion: #46061 (comment) .

@bricss
Copy link

bricss commented Jan 22, 2023

@jaydenseric check dis out #46092 (comment) 👀

@ruyadorno
Copy link
Member

super small and optional but if for some reason you decide to amend the release commit, it would be nice to remove the markdown format from the PRs linked in the commit message.

RafaelGSS added a commit that referenced this pull request Jan 24, 2023
@RafaelGSS RafaelGSS merged commit 07c9241 into v19.x Jan 24, 2023
@RafaelGSS RafaelGSS deleted the v19.5.0-proposal branch January 24, 2023 21:14
RafaelGSS added a commit that referenced this pull request Jan 24, 2023
Notable changes:

* http:
  * (SEMVER-MINOR) join authorization headers (Marco Ippolito) [#45982](#45982)
* lib:
  * add webstreams to Duplex.from() (Debadree Chatterjee) [#46190](#46190)
* stream:
  * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) [#46205](#46205)

PR-URL: #46286
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jan 24, 2023
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.