Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: make update-eslint.sh work with npm@9 #46088

Closed
wants to merge 2 commits into from
Closed

tools: make update-eslint.sh work with npm@9 #46088

wants to merge 2 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 4, 2023 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 4, 2023
lpinca
lpinca commented Jan 4, 2023
View reviewed changes
tools/update-eslint.sh Outdated
(cd node_modules/eslint && "$NODE" "$NPM" install --no-save --no-bin-links --ignore-scripts --production --omit=peer eslint-plugin-jsdoc eslint-plugin-markdown @babel/core @babel/eslint-parser @babel/plugin-syntax-import-assertions)
"$NODE" "$NPM" install \
--ignore-scripts \
--install-strategy=shallow \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --global-style option has been deprecated in favor of --install-strategy=shallow.

tools/update-eslint.sh Outdated
(
cd node_modules/eslint
"$NODE" "$NPM" uninstall \
--install-links=false \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value has been flipped.

tools/update-eslint.sh Outdated
cd node_modules/eslint
"$NODE" "$NPM" install \
--ignore-scripts \
--install-links=false \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

tools/update-eslint.sh Outdated
# Use dmn to remove some unneeded files.
"$NODE" "$NPM" exec -- dmn@2.2.2 -f clean
"$NODE" "$NPM" exec --package=dmn@2.2.2 --yes -- dmn -f clean
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why but an ENOENT error is raised with the original command.

@lpinca lpinca added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 4, 2023
@aduh95
Copy link
Contributor

aduh95 commented Jan 4, 2023

Duplicate of #45974?

@lpinca
Copy link
Member Author

lpinca commented Jan 4, 2023

I did not see #45974 but it seems it does not include the --install-links change, and it fails without it.

@aduh95
Copy link
Contributor

aduh95 commented Jan 4, 2023

I did not see #45974 but it seems it does not include the --install-links change, and it fails without it.

My PR works FWIW (yes even without --install-links), but I like yours better. Would you consider moving the script to tools/dep_updaters?

@lpinca
Copy link
Member Author

lpinca commented Jan 4, 2023 •
edited
Loading

My PR works FWIW (yes even without --install-links), but I like yours better.

It did not work on WSL (Ubuntu 22.04). I don't have access to it at the moment, but I can test again tomorrow.

Would you consider moving the script to tools/dep_updaters?

Yes, I can add a commit for it. I will do it later.

@lpinca lpinca added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 4, 2023
@lpinca
tools: make update-eslint.sh work with npm@9
2925eb2 
Make the `update-eslint.sh` script work with `npm@9`.
@lpinca
tools: move update-eslint.sh to dep_updaters/
9766106 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.
@aduh95 aduh95 mentioned this pull request Jan 4, 2023
Closed
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 6f50acd...6668c4d

nodejs-github-bot pushed a commit that referenced this pull request Jan 6, 2023
@lpinca @nodejs-github-bot
tools: make update-eslint.sh work with npm@9
7f2ef89 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 6, 2023
@lpinca @nodejs-github-bot
tools: move update-eslint.sh to dep_updaters/
6668c4d 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@lpinca lpinca deleted the fix/update-eslint-script branch January 6, 2023 09:18
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@lpinca @RafaelGSS
tools: make update-eslint.sh work with npm@9
2f25518 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: nodejs#46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@lpinca @RafaelGSS
tools: move update-eslint.sh to dep_updaters/
0e6a6bd 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: nodejs#46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@lpinca @RafaelGSS
tools: make update-eslint.sh work with npm@9
2e8750a 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@lpinca @RafaelGSS
tools: move update-eslint.sh to dep_updaters/
750fcf8 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@lpinca @juanarbol
tools: make update-eslint.sh work with npm@9
7dcc80c 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@lpinca @juanarbol
tools: move update-eslint.sh to dep_updaters/
9d43491 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@lpinca @juanarbol
tools: make update-eslint.sh work with npm@9
609df01 
Make the `update-eslint.sh` script work with `npm@9`.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@lpinca @juanarbol
tools: move update-eslint.sh to dep_updaters/
fafbd1c 
Move the `update-eslint.sh` script to the `dep_updaters/` directory.

PR-URL: #46088
Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @aduh95 @nodejs-github-bot @ruyadorno