Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing commits to v4.x-staging #4730

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 17, 2016

Adds a pair of commits that have landed in master that are currently not in v4.x-staging.

Ref: #4698

test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, nodejs#2862 fixes it and
lands soon, but until then, let's mark it as flaky.

PR-URL: nodejs#3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This extends fixes for test-https-pipeline-flood to hopefully fully
eliminate its flakiness on Windows in our continuous integration
process.

PR-URL: nodejs#3636
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Trott Trott added test Issues and PRs related to the tests. lts Issues and PRs related to Long Term Support releases. labels Jan 17, 2016
@rvagg
Copy link
Member

rvagg commented Jan 18, 2016

screen shot 2016-01-18 at 1 27 13 pm

that's what I see for this, no changes .. ?

@Trott
Copy link
Member Author

Trott commented Jan 18, 2016

Ah, I missed that a third commit moved the file into parallel and that commit has already landed on v4.x-staging. So the sum total of these two commits with that commit would be no change. Closing.

@Trott Trott closed this Jan 18, 2016
@MylesBorins
Copy link
Contributor

Can you add do-not-land-onv4.x label to the commits in question?
On Jan 18, 2016 12:12 AM, "Rich Trott" notifications@github.com wrote:

Closed #4730 #4730.


Reply to this email directly or view it on GitHub
#4730 (comment).

@Trott
Copy link
Member Author

Trott commented Jan 18, 2016

@thealphanerd I've added the label to the relevant pull requests (#3616 and #3636) and removed the other v4.x labels from #3636.

@MylesBorins MylesBorins removed their assignment Dec 27, 2016
@Trott Trott deleted the v4-missing branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lts Issues and PRs related to Long Term Support releases. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants