Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark http-pipeline-flood flaky #3616

Closed
wants to merge 1 commit into from
Closed

test: mark http-pipeline-flood flaky #3616

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 31, 2015

test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, #2862 fixes it and
lands soon, but until then, let's mark it as flaky.

Recent examples of the test failing on Windows in CI:

@Trott
test: mark http-pipeline-flood flaky
158c94c 
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, nodejs#2862 fixes it and
lands soon, but until then, let's mark it as flaky.
@Trott Trott added the test Issues and PRs related to the tests. label Oct 31, 2015
@Trott
Copy link
Member Author

Trott commented Oct 31, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/655/

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 1, 2015
@rvagg
Copy link
Member

rvagg commented Nov 1, 2015

/cc @indutny also #2862

@jbergstroem
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Nov 2, 2015

Landed in 6d6bc5d

@Trott Trott closed this Nov 2, 2015
Trott added a commit that referenced this pull request Nov 2, 2015
@Trott
test: mark http-pipeline-flood flaky
6d6bc5d 
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, #2862 fixes it and
lands soon, but until then, let's mark it as flaky.

PR-URL: #3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Fishrock123 Fishrock123 mentioned this pull request Nov 6, 2015
Closed
Trott added a commit that referenced this pull request Nov 7, 2015
@Trott @rvagg
test: mark http-pipeline-flood flaky
e302c33 
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, #2862 fixes it and
lands soon, but until then, let's mark it as flaky.

PR-URL: #3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
Merged
@MylesBorins
Copy link
Contributor

Holding off on landing this until deciding if #3636 is going to lts

@MylesBorins MylesBorins mentioned this pull request Nov 17, 2015
Closed
@MylesBorins
Copy link
Contributor

unmarking this from lts-watch as #3636 has landed in lts

@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
@MylesBorins
Copy link
Contributor

@jasnell the test is no longer flakey due to the fix in #3636 removing LTS watch

@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Closed
Trott added a commit to Trott/io.js that referenced this pull request Jan 17, 2016
@Trott
test: mark http-pipeline-flood flaky
ea58e39 
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, nodejs#2862 fixes it and
lands soon, but until then, let's mark it as flaky.

PR-URL: nodejs#3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott Trott mentioned this pull request Jan 18, 2016
Closed
@Trott Trott deleted the mark-http-pipeline-flood-flaky branch January 13, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @rvagg @jbergstroem @MylesBorins @mscdex @jasnell