Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 1b471b796022 #47399

Merged
merged 1 commit into from
May 7, 2023
Merged

deps: V8: cherry-pick 1b471b796022 #47399

merged 1 commit into from
May 7, 2023

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Apr 4, 2023

Original commit message:

[riscv] Using s8 as backtrack_stackpointer reg and optimize BranchShortHelper

1. Fix incorrect backtrack_stackpointer reg.
2. Optimize BranchShortHelper when comparing zero immediate.
3. This is a workaround CL fix v8:13836

Bug: v8:13836

Change-Id: I4cfc9df92fcd38ecd448a41ee87d1e251efd4ad9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394942
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#86889}

Refs: v8/v8@1b471b7

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 4, 2023
@luyahan
Copy link
Contributor Author

luyahan commented Apr 4, 2023

fix babel/babel#15501 on riscv

@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50904/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5270/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5270/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5270/

@luyahan luyahan mentioned this pull request Apr 4, 2023
Closed
1 task
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Apr 4, 2023
@kxxt @luyahan
upgpatch: nodejs
eaf65e9 
Apply the fix patch for v8 JIT issues.
The patch from nodejs/node#47399 won't apply to node 19.8.1
so we need to store it in our repo.

Co-authored-by: Lu Yahan <yahan@iscas.ac.cn>
@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Open
26 tasks
@kxxt kxxt mentioned this pull request Apr 5, 2023
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Apr 5, 2023
@kxxt @luyahan @felixonmars
upgpatch: nodejs
5469e88 
Apply the fix patch for v8 JIT issues.
The patch from nodejs/node#47399 won't apply to node 19.8.1
so we need to store it in our repo.

Co-authored-by: Lu Yahan <yahan@iscas.ac.cn>
@gengjiawen
Copy link
Member

@luyahan Can you rebase this PR ?

@kxxt kxxt mentioned this pull request Apr 12, 2023
Closed
@luyahan @targos
deps: V8: cherry-pick 1b471b796022
9ecd4ec 
Original commit message:

    [riscv] Using s8 as backtrack_stackpointer reg and optimize BranchShortHelper

    1. Fix incorrect backtrack_stackpointer reg.
    2. Optimize BranchShortHelper when comparing zero immediate.
    3. This is a workaround CL fix v8:13836

    Bug: v8:13836

    Change-Id: I4cfc9df92fcd38ecd448a41ee87d1e251efd4ad9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394942
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#86889}

Refs: v8/v8@1b471b7
@targos targos force-pushed the port-1b471b796022 branch from 1a48a0d to 9ecd4ec Compare May 1, 2023 11:31
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51563/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5347/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5347/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5347/

@github-actions github-actions bot mentioned this pull request May 3, 2023
Open
33 tasks
This was referenced May 4, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51645/

@github-actions github-actions bot mentioned this pull request May 6, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51688/

@github-actions github-actions bot mentioned this pull request May 7, 2023
Open
27 tasks
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4040a90 into nodejs:main May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4040a90

This was referenced May 8, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
@luyahan @targos
deps: V8: cherry-pick 1b471b796022
cad42e7 
Original commit message:

    [riscv] Using s8 as backtrack_stackpointer reg and optimize BranchShortHelper

    1. Fix incorrect backtrack_stackpointer reg.
    2. Optimize BranchShortHelper when comparing zero immediate.
    3. This is a workaround CL fix v8:13836

    Bug: v8:13836

    Change-Id: I4cfc9df92fcd38ecd448a41ee87d1e251efd4ad9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4394942
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#86889}

Refs: v8/v8@1b471b7
PR-URL: #47399
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request May 20, 2023
@kxxt
upgpatch: nodejs
79fee03 
Upstream landed the V8 jit fix in v20.2.0

See also:

- nodejs/node#47399
- nodejs/node#48020
@kxxt kxxt mentioned this pull request May 20, 2023
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request May 20, 2023
@kxxt @felixonmars
upgpatch: nodejs
58d45bf 
Upstream landed the V8 jit fix in v20.2.0

See also:

- nodejs/node#47399
- nodejs/node#48020
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@luyahan @nodejs-github-bot @gengjiawen @jasnell @targos @danielleadams @debadree25