v20.2.0 release proposal #48020
Merged
v20.2.0 release proposal #48020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD uses SIGBUS after update to v12.4. Refs: nodejs/build#3134 PR-URL: #47851 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #47498 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #47789 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #47789 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #47826 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Remove EOL release lines and add missing supported release lines. PR-URL: #47835 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: #47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #47768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
PR-URL: #47768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
PR-URL: #47768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This patch moves the initialization of per-isolate properties of the bindings that are in the embedded snapshot separate from the initialization of their per-context properties. This is necessary for workers to share the isolate snapshot with the main thread and deserialize these properties instead of creating them from scratch. PR-URL: #47768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
The pattern of getting the address of the element at index 0 of a container is generally used to materialize a pointer to the backing data of a container, however `std::string` and `std::vector` provide a `data()` accessor to retrieve the data pointer which should be preferred. This also ensures that in the case that the container is empty, the data pointer access does not perform an errant memory access. PR-URL: #47750 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.3. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@d9f34f8...894ff02) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #47807 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.3.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@04df126...f3feb00) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #47809 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #47833 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #47803 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #47760 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Previously we didn't pass the snapshot data down to the isolate data of workers so workers spawned by workers won't use the snapshot. Fixes it by passing the snapshot data down. PR-URL: #47731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #47660 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Previously, the `require()` function exposed to the embedded SEA code was calling the internal `require()` function if the module name belonged to the list of public core modules but the internal `require()` function does not support loading modules with the "node:" prefix, so this change forwards the calls to another `require()` function that supports this. Fixes: nodejs/single-executable#69 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47779 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Refs: nodejs/single-executable#60 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47588 Fixes: #47741 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm. PR-URL: #47437 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Address coverity warning about uninitialized value Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #47753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Having Utf8Value::operator==() without operator!=() is awkward in C++17, so add the negated equality operator. Then, use either instead of strcmp() where appropriate. PR-URL: #47827 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #47831 Fixes: #47828 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
PR-URL: #47834 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
The http2 implementation uses the deprecated function nghttp2_session_callbacks_set_error_callback, which does not supply an error code but only an error message. This so far forced node's error callback to rely on the error message in order to distinguish between different errors, which is fragile and inefficient. Use the newer nghttp2_session_callbacks_set_error_callback2 function instead, which is not deprecated and which provides the exact error code to node's error callback. PR-URL: #47840 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #45715 Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
nodejs-github-bot
added
meta
RafaelGSS
approved these changes
May 15, 2023
tniessen
approved these changes
May 15, 2023
19 tasks
aduh95
approved these changes
May 16, 2023
|
Release build is done. I'll promote in a few hours. |
targos
added a commit
that referenced
this pull request
May 16, 2023
Notable changes: doc: * add ovflowd to collaborators (Claudio Wunder) #47844 http: * (SEMVER-MINOR) prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732 sea: * (SEMVER-MINOR) add option to disable the experimental SEA warning (Darshan Sen) #47588 test_runner: * (SEMVER-MINOR) add `skip`, `todo`, and `only` shorthands to `test` (Chemi Atlow) #47909 url: * (SEMVER-MINOR) add value argument to `URLSearchParams` `has` and `delete` methods (Sankalp Shubham) #47885 PR-URL: #48020
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
May 16, 2023
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
May 16, 2023
This was referenced May 17, 2023
kxxt
added a commit
to kxxt/archriscv-packages
that referenced
this pull request
May 20, 2023
Upstream landed the V8 jit fix in v20.2.0 See also: - nodejs/node#47399 - nodejs/node#48020
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
May 20, 2023
Upstream landed the V8 jit fix in v20.2.0 See also: - nodejs/node#47399 - nodejs/node#48020
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-05-16, Version 20.2.0 (Current), @targos
Notable Changes
c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #478444197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #4758817befe008c] - (SEMVER-MINOR) test_runner: addskip,todo, andonlyshorthands totest(Chemi Atlow) #47909a0634d7f89] - (SEMVER-MINOR) url: add value argument toURLSearchParamshasanddeletemethods (Sankalp Shubham) #47885Commits
456fca0d9c] - bootstrap: initialize per-isolate properties of bindings separately (Joyee Cheung) #47768d6d12bf978] - bootstrap: log isolate data info in mksnapshot debug logs (Joyee Cheung) #47768e457d89a1b] - buffer: combine checking range of sourceStart inbuf.copy(Deokjin Kim) #4775800668fcfb4] - child_process: use signal.reason in child process abort (Debadree Chatterjee) #47817d7993474ea] - crypto: remove default encoding from scrypt (Tobias Nießen) #4794309fb74a7cc] - crypto: fix webcrypto private/secret import with empty usages (Filip Skokan) #47877e9c6ee74f3] - crypto: remove default encoding from pbkdf2 (Tobias Nießen) #47869b7f13a8679] - deps: update simdutf to 3.2.9 (Node.js GitHub Bot) #47983b16f6da153] - deps: V8: cherry-pick 5f025d1ca2ca (Michaël Zasso) #4761099f8fcab45] - deps: V8: cherry-pick a8a11a87cb72 (Michaël Zasso) #47610c2b14b4c78] - deps: update ada to 2.4.0 (Node.js GitHub Bot) #47922cad42e7a56] - deps: V8: cherry-pick 1b471b796022 (Lu Yahan) #473997b2f17ca59] - deps: upgrade npm to 9.6.6 (npm team) #47862d23b1af562] - deps: update ada to 2.3.1 (Node.js GitHub Bot) #4789372340c98fb] - dgram: convert macro to template (Tobias Nießen) #478919be922892f] - dns: callada::idna::to_asciidirectly from c++ (Yagiz Nizipli) #479204a1e97156a] - doc: add missing deprecated blocks to cluster (Tobias Nießen) #4798113118a19ee] - doc: update description of global (Tobias Nießen) #47969372796440b] - doc: update measure memory rejection information (Yash Ladha) #416397ecc6740e4] - doc: fix broken link to TC39 import attributes proposal (Rich Trott) #47954b9771c95c7] - doc: fix broken link (Rich Trott) #479536f5ba92e61] - doc: remove broken link (Rich Trott) #47942c9ffc555f1] - doc: document make lint-md-clean (Matteo Collina) #479267ed99e8ba5] - doc: mark global object as legacy (Mert Can Altın) #47819bf39f2d252] - doc: ntfs junction points must link to directories (Ben Noordhuis) #479074dfc3890d8] - doc: improvepermission.hasdescription (Daeyeon Jeong) #4787593f1aa2856] - doc: fix params names (Dmitry Semigradsky) #478539a362aa2fb] - doc: update supported version of FreeBSD to 12.4 (Michaël Zasso) #4783889c70dc6e6] - doc: add stability experimental to pm (Rafael Gonzaga) #47890f96fb2eee7] - doc: swap Matteo with Rafael in the stewards (Rafael Gonzaga) #478411666a146e3] - doc: add valgrind suppression details (Kevin Eady) #47760e53e8231ff] - doc: replace EOL versions in README (Tobias Nießen) #47833c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #47844f7106765b3] - doc: update BUILDING.md previous versions links (Tobias Nießen) #47835811b43c215] - doc,test: update the v8.startupSnapshot doc and test the example (Joyee Cheung) #474681ec640ac70] - esm: do not use'beforeExit'on the main thread (Antoine du Hamel) #47964106dc612d6] - fs: make readdir recursive algorithm iterative (Ethan Arrowood) #47650a0da2348a8] - fs: move fs_use_promises_symbol to per-isolate symbols (Joyee Cheung) #477684197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #47732a4d6543598] - http2: improve nghttp2 error callback (Tobias Nießen) #47840a4fed6c580] - lib: update comment (sinkhaha) #47884fd8bec7b2b] - meta: bump step-security/harden-runner from 2.3.1 to 2.4.0 (Rich Trott) #47980f5b4b6d5dc] - meta: bump github/codeql-action from 2.3.2 to 2.3.3 (Rich Trott) #47979c05c0a2359] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (Rich Trott) #479682a3d6d97cb] - meta: add security-wg ping to permission.js (Rafael Gonzaga) #479416c158e8dd1] - meta: bump step-security/harden-runner from 2.2.1 to 2.3.1 (dependabot[bot]) #47808f7a8094d37] - meta: bump actions/setup-python from 4.5.0 to 4.6.0 (dependabot[bot]) #478060f58e48792] - meta: bump actions/checkout from 3.3.0 to 3.5.2 (dependabot[bot]) #47805652b06dd82] - meta: remove extra space in scorecard workflow (Mestery) #478059f06eaccaf] - meta: bump github/codeql-action from 2.2.9 to 2.3.2 (dependabot[bot]) #47809977fd7cf35] - meta: bump codecov/codecov-action from 3.1.1 to 3.1.3 (dependabot[bot]) #47807c19385c154] - module: refactor to usenormalizeRequirableIdin the CJS module loader (Darshan Sen) #47896739113f2fc] - module: block requiringtest/reporterswithout scheme (Moshe Atlow) #47831f489c6710c] - (NODE-API-SEMVER-MAJOR) node-api: get Node API version used by addon (Vladimir Morozov) #457157222f9d74b] - path: indicate index of wrong resolve() parameter (sosoba) #476607dd32f1536] - permission: remove unused function declaration (Deokjin Kim) #47957af86625a05] - permission: resolve reference to absolute path only for fs permission (Daeyeon Jeong) #479301625ae11fe] - quic: address recent coverity warning (Michael Dawson) #47753c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #475881a7fc186bc] - sea: allow requiring core modules with the "node:" prefix (Darshan Sen) #47779786a1c5398] - src: deduplicate X509Certificate::Fingerprint* (Tobias Nießen) #47978060c1d502b] - src: stop copying code cache, part 2 (Keyhan Vakil) #479581aec718619] - (SEMVER-MINOR) src: add cjs_module_lexer_version base64_version (Jithil P Ponnan) #456290c06bfd8dc] - src: move BlobSerializerDeserializer to a separate header file (Darshan Sen) #47933bd553e7521] - src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN (Tobias Nießen) #47845190596c189] - src: register external references for source code (Keyhan Vakil) #470554293cc47f4] - src: support V8 experimental shared values in messaging (Shu-yu Guo) #477069bc5d78f0c] - src: register ext reference for Fingerprint512 (Tobias Nießen) #47892a11507e23b] - src: stop copying code cache (Keyhan Vakil) #47144515c9b8de6] - src: clarify the parameter name inPermission::Apply(Daeyeon Jeong) #47874c4217613f5] - src: fix creating an ArrayBuffer from a Blob created withopenAsBlob(Daeyeon Jeong) #476914bc17fd67b] - src: avoid strcmp() with Utf8Value (Tobias Nießen) #47827d358317f70] - src: get binding data store directly from the realm (Joyee Cheung) #47437b04d51a0b5] - src: prefer data accessor of string and vector (Mohammed Keyvanzadeh) #477502952cc576c] - src: add per-isolate SetFastMethod and Set[Fast]MethodNoSideEffect (Joyee Cheung) #47768010d2ecf94] - test: mark test-esm-loader-http-imports as flaky (Tobias Nießen) #47987bb33c74c07] - test: add getRandomValues return length (Jithil P Ponnan) #463576e019586f7] - test: unskip negative-settimeout.any.js WPT (Filip Skokan) #479468f547afe5f] - test: use appropriate usages for a negative import test (Filip Skokan) #478787e34f77518] - test: fix webcrypto wrap unwrap tests (Filip Skokan) #4787630f4f35244] - test: fix output tests when path includes node version (Moshe Atlow) #4784354607bfd68] - test: reduce WPT concurrency (Filip Skokan) #4783417945a2495] - test: migrate a pseudo_tty test to use assertSnapshot (Moshe Atlow) #47803c9233679e8] - test: fix WPT state when process exits but workers are still running (Filip Skokan) #4782634bfb69b5b] - test: migrate message tests to use assertSnapshot (Moshe Atlow) #47498d25c785c2a] - test: allow SIGBUS in signal-handler abort test (Michaël Zasso) #47851aa2c7e00d7] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #47921da27542058] - test_runner: use v8.serialize instead of TAP (Moshe Atlow) #4786717befe008c] - (SEMVER-MINOR) test_runner: add shorthands totest(Chemi Atlow) #4790942db1d50a0] - test_runner: fix ordering of test hooks (Phil Nash) #47931d81c54e3a8] - test_runner: omit inaccessible files from coverage (Colin Ihrig) #47850a4e261e910] - tools: debug log for nghttp3 (Marco Ippolito) #47992f6ff318d4c] - tools: automate icu-small update (Marco Ippolito) #47727706c305381] - tools: update lint-md-dependencies to rollup@3.21.5 (Node.js GitHub Bot) #47903e22c686ca9] - tools: update eslint to 8.40.0 (Node.js GitHub Bot) #4790636f7cfac93] - tools: update eslint to 8.39.0 (Node.js GitHub Bot) #477897323902a40] - tools: fix jsdoc lint (Moshe Atlow) #47789a0634d7f89] - (SEMVER-MINOR) url: add value argument to has and delete methods (Sankalp Shubham) #478851b06c1e003] - url: improveisURLdetection (Yagiz Nizipli) #478862bd869d20c] - vm: fix crash when setting __proto__ on context's globalThis (Feng Yu) #47939e6685f9e82] - vm,lib: refactor microtaskQueue assignment logic (Khaidi Chu) #4776547fea13dac] - worker: support more cases when (de)serializing errors (Moshe Atlow) #479256f3876c035] - worker: use snapshot in workers spawned by workers (Joyee Cheung) #47731