-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: debug log for nghttp3 #47992
tools: debug log for nghttp3 #47992
Conversation
Fast-track has been requested by @marco-ippolito. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do GitHub files have stable checksums? If so, it would be good to log the sha256sum
or so of the downloaded archive.
This is a good idea! It might be something we want to do for all archive we download. Ill look into it |
Landed in d27301d |
PR-URL: nodejs#47992 Refs: nodejs#47576 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #47576