Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: omit inaccessible files from coverage #47850

Merged
merged 1 commit into from
May 10, 2023

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 4, 2023

If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report.

If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 4, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2023

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2023
@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels May 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4360389 into nodejs:main May 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4360389

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/47850
✔  Done loading data for nodejs/node/pull/47850
----------------------------------- PR info ------------------------------------
Title      test_runner: omit inaccessible files from coverage (#47850)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cjihrig:coverage-deleted -> nodejs:main
Labels     author ready, test_runner
Commits    1
 - test_runner: omit inaccessible files from coverage
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/47850
Reviewed-By: Moshe Atlow 
Reviewed-By: Beth Griggs 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47850
Reviewed-By: Moshe Atlow 
Reviewed-By: Beth Griggs 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 04 May 2023 04:39:36 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47850#pullrequestreview-1412281965
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/47850#pullrequestreview-1420721623
   ⚠  This PR was merged on Wed, 10 May 2023 14:08:00 GMT
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-05-04T20:59:51Z: https://ci.nodejs.org/job/node-test-pull-request/51639/
- Querying data for job/node-test-pull-request/51639/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4937826311

@cjihrig cjihrig deleted the coverage-deleted branch May 10, 2023 14:16
@MoLow MoLow removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 10, 2023
targos pushed a commit that referenced this pull request May 12, 2023
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: #47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: #47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
If V8 generates code coverage for a file that is later
inaccessible to the test runner, then omit that file from the
coverage report.

PR-URL: nodejs#47850
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants