Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgram: convert macro to template #47891

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented May 6, 2023

It's not pretty either way, but a template is still preferable over a macro.

It's not pretty either way, but a template is still preferable over a
macro.
@tniessen tniessen added dgram Issues and PRs related to the dgram subsystem / UDP. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 6, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 29e6dd1 into nodejs:main May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 29e6dd1

targos pushed a commit that referenced this pull request May 12, 2023
It's not pretty either way, but a template is still preferable over a
macro.

PR-URL: #47891
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
It's not pretty either way, but a template is still preferable over a
macro.

PR-URL: #47891
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
It's not pretty either way, but a template is still preferable over a
macro.

PR-URL: nodejs#47891
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants