net: fix family autoselection timeout handling. #47860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ShogunPanda
force-pushed
the
autoselectfamily-timeout
branch
from
28763f1 to
28d9306
Compare
github-actions
bot
removed
the
request-ci
tniessen
reviewed
May 6, 2023
There was a problem hiding this comment.
As far as I can tell from https://github.com/nodejs/reliability, tests such as test-x509-escaping started being flaky with ERR_SOCKET_CONNECTION_TIMEOUT from within internalConnectMultiple in the first half of April, shortly after #46790 was merged. Is this PR a fix for those flaky tests, too?
|
@tniessen I haven't checked specifically, but I think so. |
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
jasnell
approved these changes
May 10, 2023
github-actions
bot
removed
the
request-ci
24 tasks
ShogunPanda
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2d24b29 |
23 tasks
targos
pushed a commit
that referenced
this pull request
May 12, 2023
PR-URL: #47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced May 14, 2023
|
This seems to introduce a crash in some cases: #48000 |
|
I'll exclude this change from v20.2.0 while it's being investigated. |
targos
added
the
backport-blocked-v20.x
|
Thanks @targos. I'll take a look soon |
This was referenced May 16, 2023
AnnaDamm
added a commit
to AnnaDamm/scribblehub-to-epub
that referenced
this pull request
May 18, 2023
…n a released version yet: nodejs/node#47860
|
See my update here. I think there might be additional fixes required (moving this block to here). |
targos
removed
the
backport-blocked-v20.x
targos
pushed a commit
that referenced
this pull request
Jun 4, 2023
PR-URL: #47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jun 7, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jun 21, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
added
the
backport-requested-v18.x
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 7, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 13, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Jul 17, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
mhdawson
pushed a commit
to mhdawson/io.js
that referenced
this pull request
Jul 26, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
mhdawson
pushed a commit
to mhdawson/io.js
that referenced
this pull request
Aug 4, 2023
PR-URL: nodejs#47860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ruyadorno
added
backported-to-v18.x
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes timeout handling of the family autoselection.
@nodejs/net @nodejs/tsc To ensure better user experience, I disabled the attempt timeout when connecting to the last IP address available, otherwise each connection attempt would be bound to the same (pretty low) timeout.
Do you think this is a reasonable approach? Also, is this considered a semver-major change? I think people are affected by this so we might want to include in 20.x anyway.
Fixes #47822.