Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] backport Ada v2.x to Node.js v18 #48345

Closed
wants to merge 20 commits into from
Closed

[v18.x] backport Ada v2.x to Node.js v18 #48345

wants to merge 20 commits into from

Commits on Jul 9, 2023

  1. url: remove unused kFormat from url 

    PR-URL: nodejs#46867
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    65c64b4 View commit details
    Browse the repository at this point in the history

  2. url: offload URLSearchParams initialization 

    PR-URL: nodejs#46867
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    efdd768 View commit details
    Browse the repository at this point in the history

  3. url: set formatUrl method as no side effect 

    PR-URL: nodejs#46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    17e3fd0 View commit details
    Browse the repository at this point in the history

  4. url: backport non-major changes from nodejs#46904

    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    affc2e0 View commit details
    Browse the repository at this point in the history

  5. url: allow extension of user provided URL objects 

    PR-URL: nodejs#46989
Fixes: nodejs#46981
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    @aduh95 @anonrig
    aduh95 authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    353bab0 View commit details
    Browse the repository at this point in the history

  6. url: fix array overrun in node:url::SetArgs() 

    PR-URL: nodejs#47001
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    6e9086e View commit details
    Browse the repository at this point in the history

  7. src: use std::array for passing argv in node::url 

    Implements a review suggestion from 72e971e.

Refs: nodejs#47001 (comment)
PR-URL: nodejs#47035
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @addaleax @anonrig
    addaleax authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    dab483e View commit details
    Browse the repository at this point in the history

  8. url: implement URL.canParse 

    PR-URL: nodejs#47179
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    @KhafraDev @anonrig
    KhafraDev authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    652984e View commit details
    Browse the repository at this point in the history

  9. deps: update ada to 2.0.0 

    PR-URL: nodejs#47339
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    f9259fd View commit details
    Browse the repository at this point in the history

  10. url: use ada::url_aggregator for parsing urls 

    PR-URL: nodejs#47339
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    7728eee View commit details
    Browse the repository at this point in the history

  11. url: drop ICU requirement for parsing hostnames 

    PR-URL: nodejs#47339
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    d8c2a66 View commit details
    Browse the repository at this point in the history

  12. url: handle URL.canParse without base parameter 

    PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @anonrig
    anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    5824a9e View commit details
    Browse the repository at this point in the history

  13. deps: update ada to 2.1.0 

    PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    5e69ee9 View commit details
    Browse the repository at this point in the history

  14. deps: update ada to 2.2.0 

    PR-URL: nodejs#47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    40d27a7 View commit details
    Browse the repository at this point in the history

  15. deps: update ada to 2.3.0 

    PR-URL: nodejs#47737
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    3c87e8f View commit details
    Browse the repository at this point in the history

  16. deps: update ada to 2.3.1 

    PR-URL: nodejs#47893
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    18b1f55 View commit details
    Browse the repository at this point in the history

  17. deps: update ada to 2.4.0 

    PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    461c1e9 View commit details
    Browse the repository at this point in the history

  18. deps: update ada to 2.4.1 

    PR-URL: nodejs#48036
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    5931018 View commit details
    Browse the repository at this point in the history

  19. deps: update ada to 2.4.2 

    PR-URL: nodejs#48092
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    173748c View commit details
    Browse the repository at this point in the history

  20. deps: update ada to 2.5.0 

    PR-URL: nodejs#48223
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @nodejs-github-bot @anonrig
    nodejs-github-bot authored and anonrig committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    054f967 View commit details
    Browse the repository at this point in the history