Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix loading of (recursive) CJS modules from ESM #49500

Merged
merged 1 commit into from
Sep 6, 2023
Merged

esm: fix loading of (recursive) CJS modules from ESM #49500

merged 1 commit into from
Sep 6, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 5, 2023

Fixes: #49497

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 5, 2023
@lilnasy lilnasy mentioned this pull request Sep 5, 2023
Closed
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53745/

@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53760/

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Fast-track has been requested by @aduh95. Please 👍 to approve.

@JakobJingleheimer
Copy link
Member

Approving fast-track per:

node/doc/contributing/collaborator-guide.md

Line 186 in d8eb8d0

* Regressions that happen right before a release, or reported soon after.

introduced in 20.6.0 released yesterday

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit fdc65d9 into nodejs:main Sep 6, 2023
43 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fdc65d9

@aduh95 aduh95 deleted the fix-cjs-recursive branch September 6, 2023 10:12
@camcamd camcamd mentioned this pull request Sep 6, 2023
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 6, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Open
20 tasks
This was referenced Sep 7, 2023
Merged
Merged
@azu azu mentioned this pull request Sep 7, 2023
Merged
@dustinnewman dustinnewman mentioned this pull request Sep 7, 2023
Closed
1 task
@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Sep 7, 2023 •
edited
Loading

Hey, is there any indication for when we could expect this PR to be released? Multiple major projects are waiting for this regression fix: Babel, Angular, Astro, Nuxt, Vite

@w3nl
Copy link

w3nl commented Sep 7, 2023

This is the release schedule (expectation dates)
nodejs/Release#855

@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Sep 7, 2023 •
edited
Loading

Thank you! It looks like there are only planned dates for the next minor versions there.

@UlisesGascon I see that you released 20.6.0 and are working on 20.7.0, maybe you can help here? :)

@RafaelGSS
Copy link
Member

I'll create the v20.6.1 proposal. But, I won't be able to sign and promote (I'm travelling) - ping @nodejs/releasers.

RafaelGSS pushed a commit that referenced this pull request Sep 7, 2023
@aduh95 @RafaelGSS
esm: fix loading of CJS modules from ESM
8acbe6d 
PR-URL: #49500
Fixes: #49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS added a commit that referenced this pull request Sep 7, 2023
@RafaelGSS
2023-09-08, Version 20.6.1 (Current)
0d92ff0 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: TBD
@RafaelGSS RafaelGSS mentioned this pull request Sep 7, 2023
Merged
@RafaelGSS
Copy link
Member

#49528

@UlisesGascon
Copy link
Member

I have bandwidth for it @RafaelGSS @nicolo-ribaudo, I can promote it but I will need first to unblock nodejs/Release#892 🙂

RafaelGSS added a commit that referenced this pull request Sep 7, 2023
@RafaelGSS
2023-09-08, Version 20.6.1 (Current)
d2c7c36 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Open
26 tasks
@webpro webpro mentioned this pull request Sep 8, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
@RafaelGSS @ruyadorno
2023-09-08, Version 20.6.1 (Current)
0a2ab4c 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528
@github-actions github-actions bot mentioned this pull request Sep 9, 2023
Open
24 tasks
@egeres egeres mentioned this pull request Sep 12, 2023
Closed
1 task
@shamoon shamoon mentioned this pull request Sep 14, 2023
Merged
11 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @alexfernandez
esm: fix loading of CJS modules from ESM
d5305bf 
PR-URL: nodejs#49500
Fixes: nodejs#49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@RafaelGSS @alexfernandez
2023-09-08, Version 20.6.1 (Current)
5d8d9e3 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) nodejs#49500

PR-URL: nodejs#49528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@Jason3S Jason3S Jason3S left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments

@Qard Qard Qard approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM