Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully when encountering a Node.js bug #8412

Closed
wants to merge 4 commits into from

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Sep 5, 2023

Changes

Closes #8411
image

Testing

Does not affect behavior. Existing tests should pass.

Docs

Does not affect usage.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: ffe565e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy
Copy link
Member

bluwy commented Sep 5, 2023

I'm not really sure if we should do anything due to a Node.js bug, it looks like an urgent regression affecting many other projects and the Node issue shows there's currently work on it.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking this for now to see if Node will be fixing this soon. If not we can go ahead and merge this.

@ematipico
Copy link
Member

I also think we should wait and see.

@lilnasy
Copy link
Contributor Author

lilnasy commented Sep 5, 2023

I agree about waiting. Although, a warning by astro would be helpful because the issue will probably send users on a wild goose chase. I doubt many will expect it to be because of node.

If the majority opinion is against it, I don't mind closing this PR.

@lilnasy
Copy link
Contributor Author

lilnasy commented Sep 5, 2023

Has a PR: nodejs/node#49500

@lilnasy
Copy link
Contributor Author

lilnasy commented Sep 6, 2023

The PR was merged, although node is yet to cut a release.

@natemoo-re
Copy link
Member

Node will surely cut a release soon, now that a fix has been merged. I'm going to close this, but appreciate the PR as always!

@natemoo-re natemoo-re closed this Sep 6, 2023
@lilnasy lilnasy deleted the node-20-6-helpful-error branch September 20, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with Node 20.6
5 participants