-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit gracefully when encountering a Node.js bug #8412
Conversation
🦋 Changeset detectedLatest commit: ffe565e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm not really sure if we should do anything due to a Node.js bug, it looks like an urgent regression affecting many other projects and the Node issue shows there's currently work on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily blocking this for now to see if Node will be fixing this soon. If not we can go ahead and merge this.
I also think we should wait and see. |
I agree about waiting. Although, a warning by astro would be helpful because the issue will probably send users on a wild goose chase. I doubt many will expect it to be because of node. If the majority opinion is against it, I don't mind closing this PR. |
Has a PR: nodejs/node#49500 |
The PR was merged, although node is yet to cut a release. |
Node will surely cut a release soon, now that a fix has been merged. I'm going to close this, but appreciate the PR as always! |
Changes
Closes #8411
Testing
Does not affect behavior. Existing tests should pass.
Docs
Does not affect usage.